CoreAnimation: Give app windows layers

CoreAnimation: Give app windows layers

On 10.6-10.8, there is a brief flicker of corruption when the
RWHVCocoa (which has a CALayer) is added to the already-visible
window's NSView hierarchy. I suspect that this is a mini-seizure
that the window system has when transitioning the window from
a "does not have layers" mode to a "has layers" mode. Adding a
layer to the window's NSView hierarchy before the window is made
visible makes this seizure not happen.

BUG=356627
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260268

[ccameron, 2014-03-27 21:57:57]

One line fix for 10.6-10.8 corruption flashes.

The explanation seems plausible to me, but is a result of the engineering
equivalent of poking with a stick.

I can guess that this isn't an issue in 10.9 because the window system is more
CALayer-inclined than it was in earlier versions.

[Andre, 2014-03-27 22:48:30]

On 2014/03/27 21:57:57, ccameron1 wrote:
> One line fix for 10.6-10.8 corruption flashes.
> 
> The explanation seems plausible to me, but is a result of the engineering
> equivalent of poking with a stick.
> 
> I can guess that this isn't an issue in 10.9 because the window system is more
> CALayer-inclined than it was in earlier versions.

lgtm

[Avi (use Gerrit), 2014-03-27 23:41:03]

This does mean that everything gets a layer, though, yes? If we won't hit the
same issues that we were hitting before, sure.

LGTM

[ccameron, 2014-03-28 08:54:22]

On 2014/03/27 23:41:03, Avi wrote:
> This does mean that everything gets a layer, though, yes? If we won't hit the
> same issues that we were hitting before, sure.
> 
> LGTM

Thanks. We went down the path of everything gets a layer for the browser window
already (some of the disastrous performance was cause by spamming repaint
messages). This just applies that to the app window (which should have nearly-no
effect).

[ccameron, 2014-03-28 08:54:29]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2014-03-28 08:56:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ccameron@chromium.org/215593002/1

[commit-bot: I haz the power, 2014-03-28 10:20:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-28 10:20:11]

Try jobs failed on following builders:
  tryserver.chromium on mac_chromium_rel

[ccameron, 2014-03-28 16:03:17]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2014-03-28 16:06:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ccameron@chromium.org/215593002/1

[ccameron, 2014-03-28 17:28:54]

On 2014/03/28 16:06:44, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
> https://chromium-status.appspot.com/cq/ccameron@chromium.org/215593002/1

Charming... the test that is failing doesn't run a single line modified by this
patch.

[commit-bot: I haz the power, 2014-03-28 17:46:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-28 17:46:01]

Try jobs failed on following builders:
  tryserver.chromium on mac_chromium_rel

[ccameron, 2014-03-28 18:52:58]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2014-03-28 18:59:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ccameron@chromium.org/215593002/1

[commit-bot: I haz the power, 2014-03-28 20:49:40]

Change committed as 260268