Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2155893002:
cc: Fix filter operation LinearIntValueBetween parameter order. (Closed)
Descriptioncc: Fix filter operation LinearIntValueBetween parameter order.
This patch fixes the order of parameters to be correct (progress
comes first).
BUG=588506
R=danakj
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
Committed: https://crrev.com/156d2a45374b05557c704d05e16f0d14e0ecea01
Cr-Commit-Position: refs/heads/master@{#406027}
Patch Set 1 #
Messages
Total messages: 17 (12 generated)
Description was changed from ========== cc: Fix filter operation LinearIntValueBetween parameter order. This patch fixes the order of parameters to be correct (progress comes first). R=danakj ========== to ========== cc: Fix filter operation LinearIntValueBetween parameter order. This patch fixes the order of parameters to be correct (progress comes first). R=danakj CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel ==========
Please take a look.
Do you wanna BUG=588506? LGTM
The CQ bit was checked by danakj@chromium.org
The CQ bit was unchecked by danakj@chromium.org
The CQ bit was unchecked by danakj@chromium.org
The CQ bit was checked by danakj@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
Description was changed from ========== cc: Fix filter operation LinearIntValueBetween parameter order. This patch fixes the order of parameters to be correct (progress comes first). R=danakj CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel ========== to ========== cc: Fix filter operation LinearIntValueBetween parameter order. This patch fixes the order of parameters to be correct (progress comes first). BUG=588506 R=danakj CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel ==========
The CQ bit was checked by vmpstr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== cc: Fix filter operation LinearIntValueBetween parameter order. This patch fixes the order of parameters to be correct (progress comes first). BUG=588506 R=danakj CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel ========== to ========== cc: Fix filter operation LinearIntValueBetween parameter order. This patch fixes the order of parameters to be correct (progress comes first). BUG=588506 R=danakj CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== cc: Fix filter operation LinearIntValueBetween parameter order. This patch fixes the order of parameters to be correct (progress comes first). BUG=588506 R=danakj CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel ========== to ========== cc: Fix filter operation LinearIntValueBetween parameter order. This patch fixes the order of parameters to be correct (progress comes first). BUG=588506 R=danakj CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel Committed: https://crrev.com/156d2a45374b05557c704d05e16f0d14e0ecea01 Cr-Commit-Position: refs/heads/master@{#406027} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/156d2a45374b05557c704d05e16f0d14e0ecea01 Cr-Commit-Position: refs/heads/master@{#406027} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
