Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2155883002: MD Downloads: change :focus effect to underline so it doesn't look like :hover (Closed)

Created:
4 years, 5 months ago by Dan Beam
Modified:
4 years, 5 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews, asanka, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-downloads_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Downloads: change :focus effect to underline so it doesn't look like :hover R=groby@chromium.org BUG=610630 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M chrome/browser/resources/md_downloads/toolbar.css View 1 chunk +9 lines, -0 lines 1 comment Download
M chrome/browser/resources/md_downloads/vulcanized.html View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
groby-ooo-7-16
lgtm https://codereview.chromium.org/2155883002/diff/1/chrome/browser/resources/md_downloads/toolbar.css File chrome/browser/resources/md_downloads/toolbar.css (right): https://codereview.chromium.org/2155883002/diff/1/chrome/browser/resources/md_downloads/toolbar.css#newcode87 chrome/browser/resources/md_downloads/toolbar.css:87: /* Applies to <paper-item>, hell if I know ...
4 years, 5 months ago (2016-07-19 17:44:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2155883002/1
4 years, 5 months ago (2016-07-19 17:45:24 UTC) #4
Dan Beam
4 years, 5 months ago (2016-07-19 17:57:18 UTC) #7
Message was sent while issue was closed. 
closed, replaced by: https://codereview.chromium.org/2157723002/

Powered by Google App Engine
This is Rietveld 408576698