Issue 2155863003: Avoid using stale UserScript pointers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2155863003: Avoid using stale UserScript pointers (Closed)

Created:
4 years, 5 months ago by robwu

Modified:
4 years, 5 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2785

Target Ref:
refs/pending/branch-heads/2785

Project:
chromium

Visibility:
Public.

More Reviews

Description

Avoid using stale UserScript pointers BUG=625393 TEST=Manually. Compile Chrome with ASAN and follow the steps from the bug report. Review-Url: https://codereview.chromium.org/2116923002 Cr-Commit-Position: refs/heads/master@{#403725} (cherry picked from commit a80776332fd8c99b58beab5d91a6675e85013628)

Patch Set 1 #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -4 lines)			Patch
	M	extensions/renderer/user_script_injector.cc	View		6 chunks	+20 lines, -4 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

robwu

4 years, 5 months ago (2016-07-16 08:59:44 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) to pending queue manually as
6f6e12045128d1589e2484960ce8c608f3df8609.

Expand Messages | Collapse Messages