Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 2155863002: [Chromecast] Default desktop windows to 720p + switch for 1080p (Closed)

Created:
4 years, 5 months ago by halliwell
Modified:
4 years, 5 months ago
Reviewers:
derekjchow1, gfhuang
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Default desktop windows to 720p + switch for 1080p This should prevent need for resizing windows when taking screenshots, although note that 1080p window option won't work on a 1080p monitor, because the window actually gets forced to be slightly smaller. 1080p window testing should be done with 4K monitor. BUG=internal b/29226425 TEST=created both 720 and 1080p windows, cast the viewport dims test page Committed: https://crrev.com/e63dea9d25f8c7d7c2f562c1bea27ba1f2d57a12 Cr-Commit-Position: refs/heads/master@{#406308}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2 lines) Patch
M chromecast/base/chromecast_switches.h View 1 chunk +4 lines, -1 line 0 comments Download
M chromecast/base/chromecast_switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chromecast/graphics/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chromecast/graphics/graphics_properties_default.cc View 2 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
halliwell
4 years, 5 months ago (2016-07-16 00:11:41 UTC) #3
halliwell
On 2016/07/16 00:11:41, halliwell wrote: ping on this
4 years, 5 months ago (2016-07-19 16:43:09 UTC) #4
gfhuang
On 2016/07/19 16:43:09, halliwell wrote: > On 2016/07/16 00:11:41, halliwell wrote: > > ping on ...
4 years, 5 months ago (2016-07-19 16:44:59 UTC) #5
derekjchow1
lgtm
4 years, 5 months ago (2016-07-19 17:03:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2155863002/1
4 years, 5 months ago (2016-07-19 17:08:16 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 17:59:27 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 18:03:19 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e63dea9d25f8c7d7c2f562c1bea27ba1f2d57a12
Cr-Commit-Position: refs/heads/master@{#406308}

Powered by Google App Engine
This is Rietveld 408576698