Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Issue 215583003: Add more details to showLineTree() output (Closed)

Created:
6 years, 9 months ago by cbiesinger
Modified:
6 years, 9 months ago
Reviewers:
pdr., ojan
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, rune+blink
Visibility:
Public.

Description

Add more details to showLineTree() output Sample of the new output: InlineFlowBox 0x397ffa898130 RenderInline 0x397ffa840170 {pos=30,13 size=212.271,15} baseline=24/20 R=ojan@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170229

Patch Set 1 #

Patch Set 2 : add missing & #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M Source/core/rendering/InlineBox.cpp View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
cbiesinger
6 years, 9 months ago (2014-03-27 23:27:33 UTC) #1
pdr.
On 2014/03/27 23:27:33, cbiesinger wrote: LGTM, I wrote almost the exact same thing last night.
6 years, 9 months ago (2014-03-27 23:31:56 UTC) #2
pdr.
On 2014/03/27 23:31:56, pdr wrote: > On 2014/03/27 23:27:33, cbiesinger wrote: > > LGTM, I ...
6 years, 9 months ago (2014-03-27 23:32:16 UTC) #3
cbiesinger
On 2014/03/27 23:32:16, pdr wrote: > On 2014/03/27 23:31:56, pdr wrote: > > On 2014/03/27 ...
6 years, 9 months ago (2014-03-27 23:43:35 UTC) #4
cbiesinger
The CQ bit was checked by cbiesinger@chromium.org
6 years, 9 months ago (2014-03-27 23:43:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cbiesinger@chromium.org/215583003/20001
6 years, 9 months ago (2014-03-27 23:43:54 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 00:32:16 UTC) #7
Message was sent while issue was closed.
Change committed as 170229

Powered by Google App Engine
This is Rietveld 408576698