Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2155793002: The parameter of the tester should have spaces in assert_selection() (Closed)

Created:
4 years, 5 months ago by joone
Modified:
4 years, 5 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

The parameter of the tester should have spaces in assert_selection() When we run assert_selection(), the tester can take one parameter, but it does not allow to have spaces. As a result, it cannot handle HTML tags as parameter. This CL allows the parameter to have spaces. BUG=none TEST=editing/assert_selection.html Committed: https://crrev.com/674e1ec92f839b188bf14498ee6c6bd9489e330a Cr-Commit-Position: refs/heads/master@{#406226}

Patch Set 1 #

Patch Set 2 : rebase on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/editing/assert_selection.html View 1 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/assert_selection.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
joone
Hi yosin@ I'm trying to allow the tester to have spaces to handle HTML tags ...
4 years, 5 months ago (2016-07-16 04:01:20 UTC) #5
yosin_UTC9
lgtm Thanks for quick work!
4 years, 5 months ago (2016-07-19 01:15:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2155793002/20001
4 years, 5 months ago (2016-07-19 01:16:18 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/257978)
4 years, 5 months ago (2016-07-19 04:58:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2155793002/20001
4 years, 5 months ago (2016-07-19 06:21:19 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-19 07:15:25 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 07:16:39 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/674e1ec92f839b188bf14498ee6c6bd9489e330a
Cr-Commit-Position: refs/heads/master@{#406226}

Powered by Google App Engine
This is Rietveld 408576698