components/sync/core/DEPS - Issue 2155763002: [Sync] //components/sync manual changes [DO NOT SUBMIT]

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/sync/core/DEPS

Issue 2155763002: [Sync] //components/sync manual changes [DO NOT SUBMIT] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@sc-automated

Patch Set: Couple format corrections. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "-sync",

3 "+components/sync/api",	2 "+components/sync/api",

4 "+components/sync/base",	3 "+components/sync/base",

5 "+components/sync/core",	4 "+components/sync/core_impl",

	5 "+components/sync/engine",

	6 "+components/sync/engine_impl",
	Nicolas Zea 2016/07/19 18:21:06 it seems odd to allow depending on impl folders fr it seems odd to allow depending on impl folders from outside of the folder. I.e. shouldn't only engine be allowed to use engine_impl? maxbogue 2016/07/19 18:58:19 Right now the _impl folders really mean "don't use Show quoted text On 2016/07/19 18:21:06, Nicolas Zea wrote: > it seems odd to allow depending on impl folders from outside of the folder. I.e. > shouldn't only engine be allowed to use engine_impl? Right now the _impl folders really mean "don't use outside of the sync component". If we layer stuff well enough it may make sense to tighten it as you say later on.
6 "+components/sync/protocol",	7 "+components/sync/protocol",

7	8 "+components/sync/sessions",

8 # TODO(tim): Remove. Bug 131130	9 "+components/sync/sessions_impl",

9 "+components/sync/base/cryptographer.h"	10 "+components/sync/syncable",

	11 "+components/sync/test",

	12 "+net",

	13 "+sql",

	14 "+third_party/leveldatabase",

10 ]	15 ]

OLD	NEW

« no previous file with comments | « components/sync/base/DEPS ('k') | components/sync/core_impl/DEPS » ('j') | components/sync/engine/DEPS » ('J')