Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2016 The Chromium Authors. All rights reserved. | 1 // Copyright 2016 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #include "chrome/browser/ui/views/extensions/chooser_dialog_view.h" | 5 #include "chrome/browser/ui/views/extensions/chooser_dialog_view.h" |
| 6 | 6 |
| 7 #include "base/macros.h" | 7 #include "base/macros.h" |
| 8 #include "base/strings/utf_string_conversions.h" | |
| 8 #include "chrome/browser/chooser_controller/mock_chooser_controller.h" | 9 #include "chrome/browser/chooser_controller/mock_chooser_controller.h" |
| 9 #include "chrome/browser/extensions/extension_browsertest.h" | 10 #include "chrome/browser/extensions/extension_browsertest.h" |
| 10 #include "chrome/browser/platform_util.h" | 11 #include "chrome/browser/platform_util.h" |
| 11 #include "chrome/browser/ui/browser_window.h" | 12 #include "chrome/browser/ui/browser_window.h" |
| 12 #include "chrome/grit/generated_resources.h" | 13 #include "chrome/browser/ui/views/chooser_content_view.h" |
| 13 #include "testing/gmock/include/gmock/gmock.h" | 14 #include "testing/gmock/include/gmock/gmock.h" |
| 14 #include "testing/gtest/include/gtest/gtest.h" | 15 #include "testing/gtest/include/gtest/gtest.h" |
| 15 #include "ui/base/l10n/l10n_util.h" | 16 #include "ui/views/controls/styled_label.h" |
| 16 #include "ui/gfx/range/range.h" | |
| 17 #include "ui/views/controls/table/table_view.h" | 17 #include "ui/views/controls/table/table_view.h" |
| 18 #include "ui/views/widget/widget.h" | 18 #include "ui/views/widget/widget.h" |
| 19 #include "ui/views/window/dialog_client_view.h" | 19 #include "ui/views/window/dialog_client_view.h" |
| 20 | 20 |
| 21 namespace { | |
| 22 | |
| 23 const char kNoDevicesFound[] = "No devices found."; | |
|
msw
2016/07/19 22:08:11
ditto nit: don't do this.
juncai
2016/07/19 22:58:24
Done.
| |
| 24 | |
| 25 } // namespace | |
| 26 | |
| 21 class ChooserDialogViewTest : public ExtensionBrowserTest { | 27 class ChooserDialogViewTest : public ExtensionBrowserTest { |
| 22 public: | 28 public: |
| 23 ChooserDialogViewTest() {} | 29 ChooserDialogViewTest() {} |
| 24 ~ChooserDialogViewTest() override {} | 30 ~ChooserDialogViewTest() override {} |
| 25 | 31 |
| 26 void SetUpOnMainThread() override { | 32 void SetUpOnMainThread() override { |
| 27 std::unique_ptr<MockChooserController> mock_chooser_controller( | 33 std::unique_ptr<MockChooserController> mock_chooser_controller( |
| 28 new MockChooserController(nullptr)); | 34 new MockChooserController(nullptr)); |
| 29 mock_chooser_controller_ = mock_chooser_controller.get(); | 35 mock_chooser_controller_ = mock_chooser_controller.get(); |
| 30 std::unique_ptr<ChooserDialogView> chooser_dialog_view( | 36 std::unique_ptr<ChooserDialogView> chooser_dialog_view( |
| 31 new ChooserDialogView(std::move(mock_chooser_controller))); | 37 new ChooserDialogView(std::move(mock_chooser_controller))); |
| 32 chooser_dialog_view_ = chooser_dialog_view.get(); | 38 chooser_dialog_view_ = chooser_dialog_view.get(); |
| 33 table_view_ = chooser_dialog_view_->table_view_for_test(); | 39 table_view_ = chooser_dialog_view_->chooser_content_view_for_test() |
| 40 ->table_view_for_test(); | |
| 34 ASSERT_TRUE(table_view_); | 41 ASSERT_TRUE(table_view_); |
| 35 table_model_ = table_view_->model(); | 42 table_model_ = table_view_->model(); |
| 36 ASSERT_TRUE(table_model_); | 43 ASSERT_TRUE(table_model_); |
| 37 views::Widget* modal_dialog = views::DialogDelegate::CreateDialogWidget( | 44 views::Widget* modal_dialog = views::DialogDelegate::CreateDialogWidget( |
| 38 chooser_dialog_view.release(), nullptr, | 45 chooser_dialog_view.release(), nullptr, |
| 39 platform_util::GetViewForWindow( | 46 platform_util::GetViewForWindow( |
| 40 browser()->window()->GetNativeWindow())); | 47 browser()->window()->GetNativeWindow())); |
| 41 modal_dialog->Show(); | 48 modal_dialog->Show(); |
| 49 styled_label_ = chooser_dialog_view_->chooser_content_view_for_test() | |
| 50 ->styled_label_for_test(); | |
| 51 ASSERT_TRUE(styled_label_); | |
| 42 } | 52 } |
| 43 | 53 |
| 44 protected: | 54 protected: |
| 45 MockChooserController* mock_chooser_controller_; | 55 MockChooserController* mock_chooser_controller_; |
| 46 ChooserDialogView* chooser_dialog_view_; | 56 ChooserDialogView* chooser_dialog_view_; |
| 47 views::TableView* table_view_; | 57 views::TableView* table_view_; |
| 48 ui::TableModel* table_model_; | 58 ui::TableModel* table_model_; |
| 59 views::StyledLabel* styled_label_; | |
| 49 | 60 |
| 50 private: | 61 private: |
| 51 DISALLOW_COPY_AND_ASSIGN(ChooserDialogViewTest); | 62 DISALLOW_COPY_AND_ASSIGN(ChooserDialogViewTest); |
| 52 }; | 63 }; |
| 53 | 64 |
| 54 IN_PROC_BROWSER_TEST_F(ChooserDialogViewTest, InitialState) { | 65 IN_PROC_BROWSER_TEST_F(ChooserDialogViewTest, InitialState) { |
| 55 // Since "No devices found." needs to be displayed on the |table_view_|, | 66 // Since "No devices found." needs to be displayed on the |table_view_|, |
| 56 // the number of rows is 1. | 67 // the number of rows is 1. |
| 57 EXPECT_EQ(table_view_->RowCount(), 1); | 68 EXPECT_EQ(1, table_view_->RowCount()); |
| 58 EXPECT_EQ( | 69 EXPECT_EQ(base::ASCIIToUTF16(kNoDevicesFound), table_model_->GetText(0, 0)); |
| 59 table_model_->GetText(0, 0), | |
| 60 l10n_util::GetStringUTF16(IDS_DEVICE_CHOOSER_NO_DEVICES_FOUND_PROMPT)); | |
| 61 // |table_view_| should be disabled since there is no option shown. | 70 // |table_view_| should be disabled since there is no option shown. |
| 62 EXPECT_FALSE(table_view_->enabled()); | 71 EXPECT_FALSE(table_view_->enabled()); |
| 63 // No option selected. | 72 // No option selected. |
| 64 EXPECT_EQ(table_view_->SelectedRowCount(), 0); | 73 EXPECT_EQ(0, table_view_->SelectedRowCount()); |
| 65 EXPECT_EQ(table_view_->FirstSelectedRow(), -1); | 74 EXPECT_EQ(-1, table_view_->FirstSelectedRow()); |
| 66 } | 75 } |
| 67 | 76 |
| 68 IN_PROC_BROWSER_TEST_F(ChooserDialogViewTest, Accept) { | 77 IN_PROC_BROWSER_TEST_F(ChooserDialogViewTest, Accept) { |
| 69 EXPECT_CALL(*mock_chooser_controller_, Select(testing::_)).Times(1); | 78 EXPECT_CALL(*mock_chooser_controller_, Select(testing::_)).Times(1); |
| 70 chooser_dialog_view_->Accept(); | 79 chooser_dialog_view_->Accept(); |
| 71 } | 80 } |
| 72 | 81 |
| 73 IN_PROC_BROWSER_TEST_F(ChooserDialogViewTest, Cancel) { | 82 IN_PROC_BROWSER_TEST_F(ChooserDialogViewTest, Cancel) { |
| 74 EXPECT_CALL(*mock_chooser_controller_, Cancel()).Times(1); | 83 EXPECT_CALL(*mock_chooser_controller_, Cancel()).Times(1); |
| 75 chooser_dialog_view_->Cancel(); | 84 chooser_dialog_view_->Cancel(); |
| 76 } | 85 } |
| 77 | 86 |
| 78 IN_PROC_BROWSER_TEST_F(ChooserDialogViewTest, Close) { | 87 IN_PROC_BROWSER_TEST_F(ChooserDialogViewTest, Close) { |
| 79 EXPECT_CALL(*mock_chooser_controller_, Close()).Times(1); | 88 EXPECT_CALL(*mock_chooser_controller_, Close()).Times(1); |
| 80 chooser_dialog_view_->Close(); | 89 chooser_dialog_view_->Close(); |
| 81 } | 90 } |
| 82 | 91 |
| 83 IN_PROC_BROWSER_TEST_F(ChooserDialogViewTest, ClickStyledLabelLink) { | 92 IN_PROC_BROWSER_TEST_F(ChooserDialogViewTest, ClickStyledLabelLink) { |
| 84 EXPECT_CALL(*mock_chooser_controller_, OpenHelpCenterUrl()).Times(1); | 93 EXPECT_CALL(*mock_chooser_controller_, OpenHelpCenterUrl()).Times(1); |
| 85 chooser_dialog_view_->StyledLabelLinkClicked(nullptr, gfx::Range(), 0); | 94 styled_label_->LinkClicked(nullptr, 0); |
| 86 } | 95 } |
| OLD | NEW |