Issue 215573002: Fixes hotword nacl handler to support the new behavior.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 215573002: Fixes hotword nacl handler to support the new behavior. (Closed)

Created:
6 years, 9 months ago by Jun Mukai

Modified:
6 years, 8 months ago

Reviewers:
cmp, xiyuan

CC:
chromium-reviews, arv+watch_chromium.org, rpetterson, gshires1

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixes hotword nacl handler to support the new behavior. - 'stopped' won't appear during initialization, the check doesn't work well. - 'audio' means recognizer has started. This is mostly harmless but better to stop when it's not used. - the recognition pattern has changed to 'hotword: ' BUG=356873 R=xiyuan@chromium.org TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260440

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -13 lines)			Patch
	M	chrome/browser/resources/app_list/plugin_manager.js	View		3 chunks	+8 lines, -13 lines	0 comments	Download
	M	chrome/browser/resources/app_list/speech_manager.js	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/215573002/1

6 years, 9 months ago (2014-03-28 00:17:11 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/215573002/1

6 years, 8 months ago (2014-03-30 16:38:07 UTC) #7

Message was sent while issue was closed.

Change committed as 260440

Expand Messages | Collapse Messages