RELAND 3: ImageCapture: Implement takePhoto() for Mac AVFoundation

RELAND 3: ImageCapture: Implement takePhoto() for Mac AVFoundation

The original patch and the previous relands broke
WebRtcWebcamBrowserTests/WebRtcWebcamBrowserTest.MANUAL_TestAcquiringAndReacquiringWebcam/0
in the WebRtc Mac-tester bots, which run using a Logitech C920.

The root cause was that for resolutions >= 1280x720p, the code
configures the use of MJPEG encoding, and that seems to produce
partially invalid JPEG markers, e.g.
(Corrupt JPEG data: 10 extraneous bytes before marker 0xd4)
that throw the AVCaptureStillImageOutput off.

This CL disconnects |stillImageOutput_| in this case.

Original description ----------------------------------------------
ImageCapture: Implement takePhoto() for Mac AVFoundation

By pulling the necessary symbols out of AVFoundation
and using them; most notably (Cr)AVCaptureStillImageOutput.

TakePhoto is already implemented for Android (both APIs).

Also adding VideoCaptureDeviceTest::MAYBE_TakePhoto
test case, enabled only for Mac.

BUG=518807
TEST=Run build with flag --enable-blink-features=ImageCapture,
navigate to [1] and push buttons
- Open Camera ...
- Create ImageCapturer
- takePhoto()  (N times!) --> profit

[1] https://rawgit.com/Miguelao/demos/master/imagecapture.html

TBR=rsesek@chromium.org since the change is trivial.

Committed: https://crrev.com/9285b1671f3eab374056de018e337d1ce0c1bf8a
Cr-Commit-Position: refs/heads/master@{#405889}

[mcasas, 2016-07-15 17:46:11]

Description was changed from

==========
RELAND 3: ImageCapture: Implement takePhoto() for Mac AVFoundation


The original patch and the previous relandings got reverted due to breaking
WebRtcWebcamBrowserTests/WebRtcWebcamBrowserTest.MANUAL_TestAcquiringAndReacquiringWebcam/0
in the WebRtc Mac-tester bots, which run using a Logitech C920.

The root cause was that for resolutions > 1280x720p, the code
configures the use of MJPEG encoding, and that seems to produce
partially invalid JPEG markers, e.g.
(Corrupt JPEG data: 10 extraneous bytes before marker 0xd4)
that throw the AVCaptureStillImageOutput off.

This CL disconnects |stillImageOutput_| in this case.


Original description ----------------------------------------------
ImageCapture: Implement takePhoto() for Mac AVFoundation

By pulling the necessary symbols out of AVFoundation
and using them; most notably (Cr)AVCaptureStillImageOutput.

TakePhoto is already implemented for Android (both APIs).

Also adding VideoCaptureDeviceTest::MAYBE_TakePhoto
test case, enabled only for Mac.

BUG=518807
TEST=Run build with flag --enable-blink-features=ImageCapture,
navigate to [1] and push buttons
- Open Camera ...
- Create ImageCapturer
- takePhoto()  (N times!) --> profit

[1] https://rawgit.com/Miguelao/demos/master/imagecapture.html

TBR=rsesek@chromium.org since the change is trivial.
==========

to

==========
RELAND 3: ImageCapture: Implement takePhoto() for Mac AVFoundation


The original patch and the previous relands broke
WebRtcWebcamBrowserTests/WebRtcWebcamBrowserTest.MANUAL_TestAcquiringAndReacquiringWebcam/0
in the WebRtc Mac-tester bots, which run using a Logitech C920.

The root cause was that for resolutions > 1280x720p, the code
configures the use of MJPEG encoding, and that seems to produce
partially invalid JPEG markers, e.g.
(Corrupt JPEG data: 10 extraneous bytes before marker 0xd4)
that throw the AVCaptureStillImageOutput off.

This CL disconnects |stillImageOutput_| in this case.


Original description ----------------------------------------------
ImageCapture: Implement takePhoto() for Mac AVFoundation

By pulling the necessary symbols out of AVFoundation
and using them; most notably (Cr)AVCaptureStillImageOutput.

TakePhoto is already implemented for Android (both APIs).

Also adding VideoCaptureDeviceTest::MAYBE_TakePhoto
test case, enabled only for Mac.

BUG=518807
TEST=Run build with flag --enable-blink-features=ImageCapture,
navigate to [1] and push buttons
- Open Camera ...
- Create ImageCapturer
- takePhoto()  (N times!) --> profit

[1] https://rawgit.com/Miguelao/demos/master/imagecapture.html

TBR=rsesek@chromium.org since the change is trivial.
==========

[mcasas, 2016-07-15 21:38:12]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2016-07-15 21:38:28]

Description was changed from

==========
RELAND 3: ImageCapture: Implement takePhoto() for Mac AVFoundation


The original patch and the previous relands broke
WebRtcWebcamBrowserTests/WebRtcWebcamBrowserTest.MANUAL_TestAcquiringAndReacquiringWebcam/0
in the WebRtc Mac-tester bots, which run using a Logitech C920.

The root cause was that for resolutions > 1280x720p, the code
configures the use of MJPEG encoding, and that seems to produce
partially invalid JPEG markers, e.g.
(Corrupt JPEG data: 10 extraneous bytes before marker 0xd4)
that throw the AVCaptureStillImageOutput off.

This CL disconnects |stillImageOutput_| in this case.


Original description ----------------------------------------------
ImageCapture: Implement takePhoto() for Mac AVFoundation

By pulling the necessary symbols out of AVFoundation
and using them; most notably (Cr)AVCaptureStillImageOutput.

TakePhoto is already implemented for Android (both APIs).

Also adding VideoCaptureDeviceTest::MAYBE_TakePhoto
test case, enabled only for Mac.

BUG=518807
TEST=Run build with flag --enable-blink-features=ImageCapture,
navigate to [1] and push buttons
- Open Camera ...
- Create ImageCapturer
- takePhoto()  (N times!) --> profit

[1] https://rawgit.com/Miguelao/demos/master/imagecapture.html

TBR=rsesek@chromium.org since the change is trivial.
==========

to

==========
RELAND 3: ImageCapture: Implement takePhoto() for Mac AVFoundation


The original patch and the previous relands broke
WebRtcWebcamBrowserTests/WebRtcWebcamBrowserTest.MANUAL_TestAcquiringAndReacquiringWebcam/0
in the WebRtc Mac-tester bots, which run using a Logitech C920.

The root cause was that for resolutions >= 1280x720p, the code
configures the use of MJPEG encoding, and that seems to produce
partially invalid JPEG markers, e.g.
(Corrupt JPEG data: 10 extraneous bytes before marker 0xd4)
that throw the AVCaptureStillImageOutput off.

This CL disconnects |stillImageOutput_| in this case.


Original description ----------------------------------------------
ImageCapture: Implement takePhoto() for Mac AVFoundation

By pulling the necessary symbols out of AVFoundation
and using them; most notably (Cr)AVCaptureStillImageOutput.

TakePhoto is already implemented for Android (both APIs).

Also adding VideoCaptureDeviceTest::MAYBE_TakePhoto
test case, enabled only for Mac.

BUG=518807
TEST=Run build with flag --enable-blink-features=ImageCapture,
navigate to [1] and push buttons
- Open Camera ...
- Create ImageCapturer
- takePhoto()  (N times!) --> profit

[1] https://rawgit.com/Miguelao/demos/master/imagecapture.html

TBR=rsesek@chromium.org since the change is trivial.
==========

[commit-bot: I haz the power, 2016-07-15 21:38:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 22:55:58]

Description was changed from

==========
RELAND 3: ImageCapture: Implement takePhoto() for Mac AVFoundation


The original patch and the previous relands broke
WebRtcWebcamBrowserTests/WebRtcWebcamBrowserTest.MANUAL_TestAcquiringAndReacquiringWebcam/0
in the WebRtc Mac-tester bots, which run using a Logitech C920.

The root cause was that for resolutions >= 1280x720p, the code
configures the use of MJPEG encoding, and that seems to produce
partially invalid JPEG markers, e.g.
(Corrupt JPEG data: 10 extraneous bytes before marker 0xd4)
that throw the AVCaptureStillImageOutput off.

This CL disconnects |stillImageOutput_| in this case.


Original description ----------------------------------------------
ImageCapture: Implement takePhoto() for Mac AVFoundation

By pulling the necessary symbols out of AVFoundation
and using them; most notably (Cr)AVCaptureStillImageOutput.

TakePhoto is already implemented for Android (both APIs).

Also adding VideoCaptureDeviceTest::MAYBE_TakePhoto
test case, enabled only for Mac.

BUG=518807
TEST=Run build with flag --enable-blink-features=ImageCapture,
navigate to [1] and push buttons
- Open Camera ...
- Create ImageCapturer
- takePhoto()  (N times!) --> profit

[1] https://rawgit.com/Miguelao/demos/master/imagecapture.html

TBR=rsesek@chromium.org since the change is trivial.
==========

to

==========
RELAND 3: ImageCapture: Implement takePhoto() for Mac AVFoundation


The original patch and the previous relands broke
WebRtcWebcamBrowserTests/WebRtcWebcamBrowserTest.MANUAL_TestAcquiringAndReacquiringWebcam/0
in the WebRtc Mac-tester bots, which run using a Logitech C920.

The root cause was that for resolutions >= 1280x720p, the code
configures the use of MJPEG encoding, and that seems to produce
partially invalid JPEG markers, e.g.
(Corrupt JPEG data: 10 extraneous bytes before marker 0xd4)
that throw the AVCaptureStillImageOutput off.

This CL disconnects |stillImageOutput_| in this case.


Original description ----------------------------------------------
ImageCapture: Implement takePhoto() for Mac AVFoundation

By pulling the necessary symbols out of AVFoundation
and using them; most notably (Cr)AVCaptureStillImageOutput.

TakePhoto is already implemented for Android (both APIs).

Also adding VideoCaptureDeviceTest::MAYBE_TakePhoto
test case, enabled only for Mac.

BUG=518807
TEST=Run build with flag --enable-blink-features=ImageCapture,
navigate to [1] and push buttons
- Open Camera ...
- Create ImageCapturer
- takePhoto()  (N times!) --> profit

[1] https://rawgit.com/Miguelao/demos/master/imagecapture.html

TBR=rsesek@chromium.org since the change is trivial.
==========

[commit-bot: I haz the power, 2016-07-15 22:55:59]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-15 22:56:13]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-15 22:58:41]

Description was changed from

==========
RELAND 3: ImageCapture: Implement takePhoto() for Mac AVFoundation


The original patch and the previous relands broke
WebRtcWebcamBrowserTests/WebRtcWebcamBrowserTest.MANUAL_TestAcquiringAndReacquiringWebcam/0
in the WebRtc Mac-tester bots, which run using a Logitech C920.

The root cause was that for resolutions >= 1280x720p, the code
configures the use of MJPEG encoding, and that seems to produce
partially invalid JPEG markers, e.g.
(Corrupt JPEG data: 10 extraneous bytes before marker 0xd4)
that throw the AVCaptureStillImageOutput off.

This CL disconnects |stillImageOutput_| in this case.


Original description ----------------------------------------------
ImageCapture: Implement takePhoto() for Mac AVFoundation

By pulling the necessary symbols out of AVFoundation
and using them; most notably (Cr)AVCaptureStillImageOutput.

TakePhoto is already implemented for Android (both APIs).

Also adding VideoCaptureDeviceTest::MAYBE_TakePhoto
test case, enabled only for Mac.

BUG=518807
TEST=Run build with flag --enable-blink-features=ImageCapture,
navigate to [1] and push buttons
- Open Camera ...
- Create ImageCapturer
- takePhoto()  (N times!) --> profit

[1] https://rawgit.com/Miguelao/demos/master/imagecapture.html

TBR=rsesek@chromium.org since the change is trivial.
==========

to

==========
RELAND 3: ImageCapture: Implement takePhoto() for Mac AVFoundation

The original patch and the previous relands broke
WebRtcWebcamBrowserTests/WebRtcWebcamBrowserTest.MANUAL_TestAcquiringAndReacquiringWebcam/0
in the WebRtc Mac-tester bots, which run using a Logitech C920.

The root cause was that for resolutions >= 1280x720p, the code
configures the use of MJPEG encoding, and that seems to produce
partially invalid JPEG markers, e.g.
(Corrupt JPEG data: 10 extraneous bytes before marker 0xd4)
that throw the AVCaptureStillImageOutput off.

This CL disconnects |stillImageOutput_| in this case.

Original description ----------------------------------------------
ImageCapture: Implement takePhoto() for Mac AVFoundation

By pulling the necessary symbols out of AVFoundation
and using them; most notably (Cr)AVCaptureStillImageOutput.

TakePhoto is already implemented for Android (both APIs).

Also adding VideoCaptureDeviceTest::MAYBE_TakePhoto
test case, enabled only for Mac.

BUG=518807
TEST=Run build with flag --enable-blink-features=ImageCapture,
navigate to [1] and push buttons
- Open Camera ...
- Create ImageCapturer
- takePhoto()  (N times!) --> profit

[1] https://rawgit.com/Miguelao/demos/master/imagecapture.html

TBR=rsesek@chromium.org since the change is trivial.

Committed: https://crrev.com/9285b1671f3eab374056de018e337d1ce0c1bf8a
Cr-Commit-Position: refs/heads/master@{#405889}
==========

[commit-bot: I haz the power, 2016-07-15 22:58:42]

Patchset 2 (id:??) landed as
https://crrev.com/9285b1671f3eab374056de018e337d1ce0c1bf8a
Cr-Commit-Position: refs/heads/master@{#405889}