Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2155703002: [Android] Add --adb-path arg to adb_command_line.py. (Closed)

Created:
4 years, 5 months ago by jbudorick
Modified:
4 years, 5 months ago
Reviewers:
Menglin
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Add --adb-path arg to adb_command_line.py. Some bots need to be able to configure the adb path. BUG= Committed: https://crrev.com/ecd87eb94c77653c3a387371670bc5a1ad16fc4a Cr-Commit-Position: refs/heads/master@{#405829}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M build/android/adb_command_line.py View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
jbudorick
4 years, 5 months ago (2016-07-15 16:41:51 UTC) #2
Menglin
On 2016/07/15 16:41:51, jbudorick wrote: lgtm
4 years, 5 months ago (2016-07-15 16:45:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2155703002/1
4 years, 5 months ago (2016-07-15 16:46:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/256710)
4 years, 5 months ago (2016-07-15 18:58:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2155703002/1
4 years, 5 months ago (2016-07-15 19:00:30 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 19:47:14 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 19:48:38 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ecd87eb94c77653c3a387371670bc5a1ad16fc4a
Cr-Commit-Position: refs/heads/master@{#405829}

Powered by Google App Engine
This is Rietveld 408576698