Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(911)

Issue 2155583004: Plugins: Remove obsolete check in PepperWebPluginImpl. (Closed)

Created:
4 years, 5 months ago by tommycli
Modified:
4 years, 5 months ago
Reviewers:
raymes
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plugins: Remove obsolete check in PepperWebPluginImpl. These crashes seem to have been fixed for good. The last one was in M50. BUG=588624 Committed: https://crrev.com/bd54a624d849cfcd5cbc7c113679212c02805b27 Cr-Commit-Position: refs/heads/master@{#406191}

Patch Set 1 #

Patch Set 2 : remove extra check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M content/renderer/pepper/pepper_webplugin_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/pepper/pepper_webplugin_impl.cc View 1 3 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
tommycli
raymes: PTAL, thanks!
4 years, 5 months ago (2016-07-18 23:31:13 UTC) #10
raymes
lgtm, awesome!
4 years, 5 months ago (2016-07-19 01:12:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2155583004/20001
4 years, 5 months ago (2016-07-19 01:26:05 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-19 02:24:29 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 02:24:32 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 02:26:53 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bd54a624d849cfcd5cbc7c113679212c02805b27
Cr-Commit-Position: refs/heads/master@{#406191}

Powered by Google App Engine
This is Rietveld 408576698