Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2155553002: X87: [turbofan] Introduce integer multiplication with overflow. (Closed)

Created:
4 years, 5 months ago by zhengxing.li
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Introduce integer multiplication with overflow. port 8e18a5f2a0357c6899cd32f5ab66b73d72fdd996 (r37748) original commit message: BUG= Committed: https://crrev.com/eb3723553e1b20e8710234f1dd236567a49ccde6 Cr-Commit-Position: refs/heads/master@{#37785}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M src/compiler/x87/instruction-selector-x87.cc View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 5 months ago (2016-07-15 02:35:14 UTC) #2
Weiliang
lgtm
4 years, 5 months ago (2016-07-15 04:05:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2155553002/1
4 years, 5 months ago (2016-07-15 04:07:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 04:29:57 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 04:32:41 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/eb3723553e1b20e8710234f1dd236567a49ccde6
Cr-Commit-Position: refs/heads/master@{#37785}

Powered by Google App Engine
This is Rietveld 408576698