Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(817)

Unified Diff: ppapi/native_client/src/trusted/plugin/pnacl_coordinator.h

Issue 215553002: Report some PNaCl UMA earlier, instead of in one chunk at the end. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/native_client/src/trusted/plugin/pnacl_coordinator.h
diff --git a/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.h b/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.h
index 321878b9ef7f4c3fa16e17400ced60d91787635a..20b3d85ff044e636015433e881d856b00c2ec8d7 100644
--- a/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.h
+++ b/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.h
@@ -116,6 +116,11 @@ class PnaclCoordinator: public CallbackSource<FileStreamData> {
// have been compiled.
pp::CompletionCallback GetCompileProgressCallback(int64_t bytes_compiled);
+ // Return a callback that should be notified when an interesting UMA timing
+ // is ready to be reported.
+ pp::CompletionCallback GetUMATimeCallback(const nacl::string& event_name,
+ int64_t microsecs);
+
// Get the last known load progress.
void GetCurrentProgress(int64_t* bytes_loaded, int64_t* bytes_total);
@@ -175,6 +180,10 @@ class PnaclCoordinator: public CallbackSource<FileStreamData> {
// Invoked when the read descriptor for nexe_file_ is created.
void NexeReadDidOpen(int32_t pp_error);
+ // Invoked when a UMA timing measurement from the translate thread is ready.
+ void DoUMATimeMeasure(
+ int32_t pp_error, const nacl::string& event_name, int64_t microsecs);
+
// Keeps track of the pp_error upon entry to TranslateFinished,
// for inspection after cleanup.
int32_t translate_finish_error_;
« no previous file with comments | « no previous file | ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698