Reland^2 "Don't compile functions in a context the caller doesn't have access to"

Reland^2 "Don't compile functions in a context the caller doesn't have access to"

Original issue's description:
> Don't compile functions in a context the caller doesn't have access to
>
> Instead just return undefined
>
> A side effect of this is that it's no longer possible to compile
> functions in a detached context.
>
> BUG=chromium:541703
> R=verwaest@chromium.org,bmeurer@chromium.org

BUG=chromium:541703
R=verwaest@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng

Committed: https://crrev.com/02ba244125037a59c06563e20ac617fb052f1c45
Cr-Commit-Position: refs/heads/master@{#37842}

[jochen (gone - plz use gerrit), 2016-07-15 14:01:07]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 14:01:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 14:01:19]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
     tryserver.chromium.linux
   For more details, see http://crbug.com/617627.

[jochen (gone - plz use gerrit), 2016-07-15 14:02:02]

turns out we can't just enter the function of the handler, because blink expects
that there is no entered context during microtask execution. yay :(

[commit-bot: I haz the power, 2016-07-15 16:04:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 16:04:47]

Dry run: This issue passed the CQ dry run.

[Toon Verwaest, 2016-07-18 12:54:09]

A little ugly to have these cases there, but I can't immediately think of a
better way to structure it. LGTM.

https://codereview.chromium.org/2155503004/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/2155503004/diff/1/src/api.cc#newcode8942
src/api.cc:8942: if (microtask_context_) {
Do we need the null-check here?

[jochen (gone - plz use gerrit), 2016-07-18 12:55:35]

https://codereview.chromium.org/2155503004/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/2155503004/diff/1/src/api.cc#newcode8942
src/api.cc:8942: if (microtask_context_) {
On 2016/07/18 at 12:54:09, Toon Verwaest wrote:
> Do we need the null-check here?

yeah, it's not necessarily set during GC

[jochen (gone - plz use gerrit), 2016-07-18 12:55:38]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2016-07-18 12:55:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 12:55:49]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
     tryserver.chromium.linux
   For more details, see http://crbug.com/617627.

[commit-bot: I haz the power, 2016-07-18 15:34:35]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-18 15:35:53]

Description was changed from

==========
Reland^2 "Don't compile functions in a context the caller doesn't have access
to"

Original issue's description:
> Don't compile functions in a context the caller doesn't have access to
>
> Instead just return undefined
>
> A side effect of this is that it's no longer possible to compile
> functions in a detached context.
>
> BUG=chromium:541703
> R=verwaest@chromium.org,bmeurer@chromium.org

BUG=chromium:541703
R=verwaest@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng
==========

to

==========
Reland^2 "Don't compile functions in a context the caller doesn't have access
to"

Original issue's description:
> Don't compile functions in a context the caller doesn't have access to
>
> Instead just return undefined
>
> A side effect of this is that it's no longer possible to compile
> functions in a detached context.
>
> BUG=chromium:541703
> R=verwaest@chromium.org,bmeurer@chromium.org

BUG=chromium:541703
R=verwaest@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng

Committed: https://crrev.com/02ba244125037a59c06563e20ac617fb052f1c45
Cr-Commit-Position: refs/heads/master@{#37842}
==========

[commit-bot: I haz the power, 2016-07-18 15:35:54]

Patchset 1 (id:??) landed as
https://crrev.com/02ba244125037a59c06563e20ac617fb052f1c45
Cr-Commit-Position: refs/heads/master@{#37842}