Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2155503002:
Fix dynamic plugging/unplugging audio devices may not update audio input source (Closed)
|
Created:
4 years, 5 months ago by Qiang(Joe) Xu Modified:
4 years, 5 months ago Reviewers:
jennyz CC:
chromium-reviews, oshima+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix dynamic plugging/unplugging audio devices may not update audio input source
BUG=628374
TEST=manual test looks good on https://webrtc.github.io/samples/src/content/devices/input-output/ when playing plugging and unplugging on chromeos.
Committed: https://crrev.com/6241f32406a1cf6ff4b59b00c364d28a6f7d936a
Cr-Commit-Position: refs/heads/master@{#406133}
Patch Set 1 #Patch Set 2 : check nullptr #Messages
Total messages: 23 (12 generated)
Description was changed from ========== Fix dynamic plugging/unplugging audio devices may not update audio input source BUG=628374 TEST=manual test looks good ========== to ========== Fix dynamic plugging/unplugging audio devices may not update audio input source BUG=628374 TEST=manual test looks good on https://webrtc.github.io/samples/src/content/devices/input-output/ when playing plugging and unplugging on chromeos. ==========
warx@chromium.org changed reviewers: + jennyz@chromium.org
Hi Jenny, could you help review on this? tks.
lgtm
The CQ bit was checked by warx@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by warx@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Hi Jenny, could you help re-review on this as some tests failed due to missing check of null |monitor|, ths
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/07/18 18:31:07, Qiang (Joe) Xu wrote: > Hi Jenny, could you help re-review on this as some tests failed due to missing > check of null |monitor|, ths https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium... Looks like crash on the line you add, could be a null pointer for the monitor.
On 2016/07/18 23:01:45, jennyz wrote: > On 2016/07/18 18:31:07, Qiang (Joe) Xu wrote: > > Hi Jenny, could you help re-review on this as some tests failed due to missing > > check of null |monitor|, ths > > https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium... > Looks like crash on the line you add, could be a null pointer for the monitor. Yes, that is updated in patch set 2.
The CQ bit was checked by warx@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jennyz@chromium.org Link to the patchset: https://codereview.chromium.org/2155503002/#ps20001 (title: "check nullptr")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix dynamic plugging/unplugging audio devices may not update audio input source BUG=628374 TEST=manual test looks good on https://webrtc.github.io/samples/src/content/devices/input-output/ when playing plugging and unplugging on chromeos. ========== to ========== Fix dynamic plugging/unplugging audio devices may not update audio input source BUG=628374 TEST=manual test looks good on https://webrtc.github.io/samples/src/content/devices/input-output/ when playing plugging and unplugging on chromeos. ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Fix dynamic plugging/unplugging audio devices may not update audio input source BUG=628374 TEST=manual test looks good on https://webrtc.github.io/samples/src/content/devices/input-output/ when playing plugging and unplugging on chromeos. ========== to ========== Fix dynamic plugging/unplugging audio devices may not update audio input source BUG=628374 TEST=manual test looks good on https://webrtc.github.io/samples/src/content/devices/input-output/ when playing plugging and unplugging on chromeos. Committed: https://crrev.com/6241f32406a1cf6ff4b59b00c364d28a6f7d936a Cr-Commit-Position: refs/heads/master@{#406133} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/6241f32406a1cf6ff4b59b00c364d28a6f7d936a Cr-Commit-Position: refs/heads/master@{#406133} |
