Chromium Code Reviews Chromium Code Reviews
Issue 2155493002:
Update missing/downloading/blocked/unsupported/disabled plugin UI. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: chrome/renderer/resources/plugins/blocked_plugin.html |
| diff --git a/chrome/renderer/resources/plugins/blocked_plugin.html b/chrome/renderer/resources/plugins/blocked_plugin.html |
| index 94313a13c5cfb1dae6ec8a3426330bd5b603cf14..453ae42a22eb39626ab3fb07bf332385cde6ff21 100644 |
| --- a/chrome/renderer/resources/plugins/blocked_plugin.html |
| +++ b/chrome/renderer/resources/plugins/blocked_plugin.html |
| @@ -1,53 +1,38 @@ |
| <!doctype html> |
| <html> |
| -<head> |
| -<meta charset="utf-8"> |
| -<meta name="viewport" content="width=device-width, user-scalable=no"> |
| -<if expr="not is_android"> |
|
tommycli
2016/08/05 17:06:59
Hey, I think this is still used by NonLoadablePlug
waffles
2016/08/05 21:37:41
Done.
|
| -<script> |
| -function setMessage(msg) { |
| - document.getElementById('message').textContent = msg; |
| -} |
| -function notifyDidFinishLoading() { |
| - if (plugin.didFinishLoading) |
| - plugin.didFinishLoading(); |
| + <head> |
| + <meta charset="utf-8"> |
| + <meta name="viewport" content="width=device-width, user-scalable=no"> |
| + <script> |
| + function setMessage(msg) { |
| + document.getElementById('message').textContent = msg; |
| + } |
| + function notifyDidFinishLoading() { |
| + if (plugin.didFinishLoading) |
| + plugin.didFinishLoading(); |
| - if (plugin.didFinishIconRepositionForTesting) |
| - plugin.didFinishIconRepositionForTesting(); |
| -} |
| -</script> |
| -</if> |
| -<if expr="is_android"> |
| -<script> |
| -function notifyDidFinishLoading() {} |
| -</script> |
| -</if> |
| -<link rel="stylesheet" href="plugin_placeholders.css"></link> |
| -<style> |
| -body { |
| - background-color: rgb(187, 187, 187); |
| -} |
| + if (plugin.didFinishIconRepositionForTesting) |
| + plugin.didFinishIconRepositionForTesting(); |
| + } |
| + </script> |
| + <link rel="stylesheet" href="plugin_placeholders.css"></link> |
| + <style> |
| + body { |
|
tommycli
2016/08/05 17:06:59
I wonder if this body and icon style can be consol
waffles
2016/08/05 21:37:41
Done.
|
| + background-color: #f7f7f7; |
| + color: #646464; |
| + } |
| -#plugin_icon { |
| - opacity: .6; |
| -} |
| -</style> |
| -</head> |
| + .icon { |
| + opacity: .3; |
| + } |
| + </style> |
| + </head> |
| -<body id="t" onload="notifyDidFinishLoading();"> |
| -<div i18n-values="title:name" id="outer"> |
| - <div id="inner"> |
| -<if expr="not is_android"> |
| - <div><img id="plugin_icon" src="plugin_blocked.png"></div> |
| -</if> |
| -<if expr="is_android"> |
| - <img id="plugin_icon" src="plugin_blocked_android.png"> |
| -</if> |
| - <h1 id="message" i18n-content="message"></h1> |
| - </div> |
| - <div id="close" i18n-values="title:hide;data-plugin-type:pluginType" |
| - onclick="plugin.hide();"> |
| - </div> |
| -</div> |
| -</body> |
| + <body id="t" onload="notifyDidFinishLoading();"> |
| + <div i18n-values="title:name" id="outer"> |
| + <img class="icon" |
| + src="../../../../ui/webui/resources/images/extension.svg"> |
| + <h1 id="message" i18n-content="message"></h1> |
| + </div> |
| + </body> |
| </html> |
