Update missing/downloading/blocked/unsupported/disabled plugin UI.

Update missing/downloading/blocked/unsupported/disabled plugin UI.

BUG=626107, 62082
Committed: https://crrev.com/025e686e1be72066fa73e659cccec597d8212fe2
Cr-Commit-Position: refs/heads/master@{#410187}

[waffles, 2016-07-14 22:52:36]

The CQ bit was checked by waffles@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 22:53:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 23:38:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 23:38:26]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[waffles, 2016-08-03 20:27:15]

Patchset #4 (id:60001) has been deleted

[waffles, 2016-08-03 20:27:23]

Patchset #3 (id:40001) has been deleted

[waffles, 2016-08-03 20:27:29]

The CQ bit was checked by waffles@chromium.org to run a CQ dry run

[waffles, 2016-08-03 20:27:32]

Patchset #2 (id:20001) has been deleted

[waffles, 2016-08-03 20:27:38]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-08-03 20:27:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[waffles, 2016-08-03 20:41:17]

Description was changed from

==========
Update missing/downloading/blocked/unsupported/disabled plugin UI.

BUG=626107
==========

to

==========
Update missing/downloading/blocked/unsupported/disabled plugin UI.

BUG=626107,62082
==========

[commit-bot: I haz the power, 2016-08-03 21:47:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 21:48:00]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[waffles, 2016-08-04 00:48:12]

The CQ bit was checked by waffles@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 00:48:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 01:58:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 01:58:41]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[waffles, 2016-08-04 20:00:28]

The CQ bit was checked by waffles@chromium.org to run a CQ dry run

[waffles, 2016-08-04 20:00:53]

Patchset #2 (id:100001) has been deleted

[waffles, 2016-08-04 20:00:56]

Patchset #1 (id:80001) has been deleted

[waffles, 2016-08-04 20:01:04]

Patchset #1 (id:120001) has been deleted

[commit-bot: I haz the power, 2016-08-04 20:01:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[waffles, 2016-08-04 20:01:19]

Patchset #1 (id:140001) has been deleted

[waffles, 2016-08-04 20:02:13]

waffles@chromium.org changed reviewers:
+ tommycli@chromium.org

[waffles, 2016-08-04 20:02:13]

Tommy, PTAL. Screenshots of the result are attached to the first bug, or you can
patch in the CL.

[commit-bot: I haz the power, 2016-08-04 22:28:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 22:28:03]

Dry run: This issue passed the CQ dry run.

[tommycli, 2016-08-05 17:06:59]

waffles: some feedback for you

https://codereview.chromium.org/2155493002/diff/160001/chrome/renderer/resour...
File chrome/renderer/resources/plugins/blocked_plugin.html (left):

https://codereview.chromium.org/2155493002/diff/160001/chrome/renderer/resour...
chrome/renderer/resources/plugins/blocked_plugin.html:6: <if expr="not
is_android">
Hey, I think this is still used by NonLoadablePluginPlaceholder, which is on
Android. I think the platform <if> tags are still needed.

https://codereview.chromium.org/2155493002/diff/160001/chrome/renderer/resour...
File chrome/renderer/resources/plugins/blocked_plugin.html (right):

https://codereview.chromium.org/2155493002/diff/160001/chrome/renderer/resour...
chrome/renderer/resources/plugins/blocked_plugin.html:20: body {
I wonder if this body and icon style can be consolidated into
plugin_placheolders.css.

If PluginPowerSaverBrowserTest passes, then it shouldn't have negatively
affected plugin_poster.html.

[waffles, 2016-08-05 21:37:41]

Thanks! PTAL.

https://codereview.chromium.org/2155493002/diff/160001/chrome/renderer/resour...
File chrome/renderer/resources/plugins/blocked_plugin.html (left):

https://codereview.chromium.org/2155493002/diff/160001/chrome/renderer/resour...
chrome/renderer/resources/plugins/blocked_plugin.html:6: <if expr="not
is_android">
On 2016/08/05 17:06:59, tommycli wrote:
> Hey, I think this is still used by NonLoadablePluginPlaceholder, which is on
> Android. I think the platform <if> tags are still needed.

Done.

https://codereview.chromium.org/2155493002/diff/160001/chrome/renderer/resour...
File chrome/renderer/resources/plugins/blocked_plugin.html (right):

https://codereview.chromium.org/2155493002/diff/160001/chrome/renderer/resour...
chrome/renderer/resources/plugins/blocked_plugin.html:20: body {
On 2016/08/05 17:06:59, tommycli wrote:
> I wonder if this body and icon style can be consolidated into
> plugin_placheolders.css.
> 
> If PluginPowerSaverBrowserTest passes, then it shouldn't have negatively
> affected plugin_poster.html.

Done.

[waffles, 2016-08-05 21:37:59]

The CQ bit was checked by waffles@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 21:38:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2016-08-05 21:57:15]

lgtm. No idea why that body id="t" in those two HTML files, but i can roll with
that.

[waffles, 2016-08-05 22:00:30]

On 2016/08/05 21:57:15, tommycli wrote:
> lgtm. No idea why that body id="t" in those two HTML files, but i can roll
with
> that.

Yeah, I thought it was weird, but... weirdly convenient?

[commit-bot: I haz the power, 2016-08-05 22:13:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 22:13:48]

Dry run: This issue passed the CQ dry run.

[waffles, 2016-08-05 22:14:18]

The CQ bit was checked by waffles@chromium.org

[commit-bot: I haz the power, 2016-08-05 22:14:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 22:19:05]

Description was changed from

==========
Update missing/downloading/blocked/unsupported/disabled plugin UI.

BUG=626107,62082
==========

to

==========
Update missing/downloading/blocked/unsupported/disabled plugin UI.

BUG=626107,62082
==========

[commit-bot: I haz the power, 2016-08-05 22:19:06]

Committed patchset #2 (id:180001)

[commit-bot: I haz the power, 2016-08-05 22:20:33]

Description was changed from

==========
Update missing/downloading/blocked/unsupported/disabled plugin UI.

BUG=626107,62082
==========

to

==========
Update missing/downloading/blocked/unsupported/disabled plugin UI.

BUG=626107,62082

Committed: https://crrev.com/025e686e1be72066fa73e659cccec597d8212fe2
Cr-Commit-Position: refs/heads/master@{#410187}
==========

[commit-bot: I haz the power, 2016-08-05 22:20:36]

Patchset 2 (id:??) landed as
https://crrev.com/025e686e1be72066fa73e659cccec597d8212fe2
Cr-Commit-Position: refs/heads/master@{#410187}