Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2155453003:
Worker: Clean up WorkerGlobalScope (Closed)
|
Created:
4 years, 5 months ago by nhiroki Modified:
4 years, 5 months ago Reviewers:
kinuko CC:
chromium-reviews, blink-reviews, kinuko+worker_chromium.org, falken, blink-worker-reviews_chromium.org, horo+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionWorker: Clean up WorkerGlobalScope
This CL
- does not change contents of functions,
- reorders function declarations/definitions,
- adds 'const' to some immutable fields and
- removes unnecessary header inclusions.
BUG=n/a
Committed: https://crrev.com/7c274b8ee745392641ec29dcb253f18e0beb6238
Cr-Commit-Position: refs/heads/master@{#405732}
Patch Set 1 #
Total comments: 8
Patch Set 2 : address review comments #
Messages
Total messages: 17 (11 generated)
Description was changed from ========== Worker: Clean up WorkerGlobalScope Mechanical changes only. This CL - does not change contents of functions, - adds 'const' to some immutable fields and - reorders function declarations/definitions. BUG=n/a ========== to ========== Worker: Clean up WorkerGlobalScope This CL - does not change bodies of functions, - reorders function declarations/definitions, - adds 'const' to some immutable fields and - removes unnecessary header inclusions. BUG=n/a ==========
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Worker: Clean up WorkerGlobalScope This CL - does not change bodies of functions, - reorders function declarations/definitions, - adds 'const' to some immutable fields and - removes unnecessary header inclusions. BUG=n/a ========== to ========== Worker: Clean up WorkerGlobalScope This CL - does not change contents of functions, - reorders function declarations/definitions, - adds 'const' to some immutable fields and - removes unnecessary header inclusions. BUG=n/a ==========
nhiroki@chromium.org changed reviewers: + kinuko@chromium.org
PTAL. WorkerGlobalScope looks messy to me. I'd like to clean it up before making more changes on it.
lgtm https://codereview.chromium.org/2155453003/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp (right): https://codereview.chromium.org/2155453003/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp:126: } nit: above two methods seem out-of-sync with the order in .h https://codereview.chromium.org/2155453003/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/workers/WorkerGlobalScope.h (right): https://codereview.chromium.org/2155453003/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/workers/WorkerGlobalScope.h:68: virtual void didEvaluateWorkerScript() { }; nit: { } -> {}, trailing semicolon unnecessary https://codereview.chromium.org/2155453003/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/workers/WorkerGlobalScope.h:128: WorkerThread* thread() const { return m_thread; } nit: could we change this to non-const method? (We're returning non-const ptr) https://codereview.chromium.org/2155453003/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/workers/WorkerGlobalScope.h:155: void didUpdateSecurityOrigin() final { } { } -> {}
Thank you! https://codereview.chromium.org/2155453003/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp (right): https://codereview.chromium.org/2155453003/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp:126: } On 2016/07/15 07:50:17, kinuko wrote: > nit: above two methods seem out-of-sync with the order in .h Done. https://codereview.chromium.org/2155453003/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/workers/WorkerGlobalScope.h (right): https://codereview.chromium.org/2155453003/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/workers/WorkerGlobalScope.h:68: virtual void didEvaluateWorkerScript() { }; On 2016/07/15 07:50:17, kinuko wrote: > nit: { } -> {}, trailing semicolon unnecessary Done. https://codereview.chromium.org/2155453003/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/workers/WorkerGlobalScope.h:128: WorkerThread* thread() const { return m_thread; } On 2016/07/15 07:50:17, kinuko wrote: > nit: could we change this to non-const method? (We're returning non-const ptr) Removing 'const' seems to affect tons of files because ExecutionContext::isContextThread() etc depend on it... I'll try it in a separate CL. https://codereview.chromium.org/2155453003/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/workers/WorkerGlobalScope.h:155: void didUpdateSecurityOrigin() final { } On 2016/07/15 07:50:17, kinuko wrote: > { } -> {} Done.
The CQ bit was checked by nhiroki@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kinuko@chromium.org Link to the patchset: https://codereview.chromium.org/2155453003/#ps60001 (title: "address review comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Worker: Clean up WorkerGlobalScope This CL - does not change contents of functions, - reorders function declarations/definitions, - adds 'const' to some immutable fields and - removes unnecessary header inclusions. BUG=n/a ========== to ========== Worker: Clean up WorkerGlobalScope This CL - does not change contents of functions, - reorders function declarations/definitions, - adds 'const' to some immutable fields and - removes unnecessary header inclusions. BUG=n/a ==========
Message was sent while issue was closed.
Committed patchset #2 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Worker: Clean up WorkerGlobalScope This CL - does not change contents of functions, - reorders function declarations/definitions, - adds 'const' to some immutable fields and - removes unnecessary header inclusions. BUG=n/a ========== to ========== Worker: Clean up WorkerGlobalScope This CL - does not change contents of functions, - reorders function declarations/definitions, - adds 'const' to some immutable fields and - removes unnecessary header inclusions. BUG=n/a Committed: https://crrev.com/7c274b8ee745392641ec29dcb253f18e0beb6238 Cr-Commit-Position: refs/heads/master@{#405732} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/7c274b8ee745392641ec29dcb253f18e0beb6238 Cr-Commit-Position: refs/heads/master@{#405732} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
