Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2155423003: Revert r404778 and r405887. (Closed)

Created:
4 years, 5 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert r404778 and r405887. These patches attempted to simplify how website permissions were handled on Android and add new code to display USB device permissions. Unfortunately the first has caused a regression for other permission types so I will revert both until we have a better solution. BUG=430999, 601627, 628986 TBR=twellington@chromium.org,bauerb@chromium.org Committed: https://crrev.com/d746e82173895858a05b3b21912f20c24f22eb9c Cr-Commit-Position: refs/heads/master@{#406420}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -300 lines) Patch
D chrome/android/java/res/drawable-hdpi/settings_usb.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/settings_usb.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/settings_usb.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/settings_usb.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxxhdpi/settings_usb.png View Binary file 0 comments Download
D chrome/android/java/res/layout/usb_permission.xml View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java View 9 chunks +66 lines, -112 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/preferences/website/UsbInfo.java View 1 chunk +0 lines, -45 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/Website.java View 2 chunks +0 lines, -29 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePermissionsFetcher.java View 3 chunks +4 lines, -14 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreferenceBridge.java View 3 chunks +0 lines, -24 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/android/java_sources.gni View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/preferences/website_preference_bridge.cc View 4 chunks +1 line, -58 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2155423003/1
4 years, 5 months ago (2016-07-19 21:18:55 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 23:58:53 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 23:58:54 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 00:00:52 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d746e82173895858a05b3b21912f20c24f22eb9c
Cr-Commit-Position: refs/heads/master@{#406420}

Powered by Google App Engine
This is Rietveld 408576698