Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2155413002: [DevTools] Node.js compatibility (Closed)

Created:
4 years, 5 months ago by eostroukhov-old
Modified:
4 years, 5 months ago
Reviewers:
kozy, eostroukhov, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Node.js compatibility 1. CodeGenerator.py correctly detects directory structure. 2. Initializer lists are no longer used with std::vector BUG=628794 Committed: https://crrev.com/1321cc19c5cf167da9e4420256dab65c28bef2fd Cr-Commit-Position: refs/heads/master@{#406302}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
eostroukhov
4 years, 5 months ago (2016-07-19 00:55:08 UTC) #4
kozy
lgtm
4 years, 5 months ago (2016-07-19 01:00:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2155413002/1
4 years, 5 months ago (2016-07-19 17:10:02 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 17:16:30 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 17:18:20 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 17:19:46 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1321cc19c5cf167da9e4420256dab65c28bef2fd
Cr-Commit-Position: refs/heads/master@{#406302}

Powered by Google App Engine
This is Rietveld 408576698