Enable Android support for Chromoting PINless (paired) authentication

Enable Android support for Chromoting PINless (paired) authentication

No more typing all those annoying passwords! This also fixes an annoying bug where right-click events were often misplaced.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216250

[solb, 2013-08-01 13:23:28]

This one's (finally) ready for review! It took much longer than I'd expected to
get this working...

[garykac, 2013-08-06 20:50:31]

https://codereview.chromium.org/21554002/diff/1/remoting/android/java/src/org...
File remoting/android/java/src/org/chromium/chromoting/DesktopView.java (right):

https://codereview.chromium.org/21554002/diff/1/remoting/android/java/src/org...
remoting/android/java/src/org/chromium/chromoting/DesktopView.java:412:
handleMouseMovement(new float[] {coordinates[0], coordinates[1]},
Why is this necessary?

https://codereview.chromium.org/21554002/diff/1/remoting/android/java/src/org...
File remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java
(right):

https://codereview.chromium.org/21554002/diff/1/remoting/android/java/src/org...
remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java:99:
prefs.getString(hostId+"_id", ""), prefs.getString(hostId+"_secret", ""));
spaces around operators

https://codereview.chromium.org/21554002/diff/1/remoting/android/java/src/org...
remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java:205:
R.id.pin_dialog_check)).isChecked());
Those parameters jumble together into a mess.

Something like:

authenticationResponse(
       
String.valueOf(((TextView)pinEntry.findViewById(R.id.pin_dialog_text)).getText()),
        ((CheckBox)pinEntry.findViewById(R.id.pin_dialog_check)).isChecked());

would be more readable.

https://codereview.chromium.org/21554002/diff/1/remoting/android/java/src/org...
remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java:250:
putString(host+"_id", new String(id)).
spaces around operators

[solb, 2013-08-07 04:30:46]

https://codereview.chromium.org/21554002/diff/1/remoting/android/java/src/org...
File remoting/android/java/src/org/chromium/chromoting/DesktopView.java (right):

https://codereview.chromium.org/21554002/diff/1/remoting/android/java/src/org...
remoting/android/java/src/org/chromium/chromoting/DesktopView.java:412:
handleMouseMovement(new float[] {coordinates[0], coordinates[1]},
On 2013/08/06 20:50:32, garykac wrote:
> Why is this necessary?

Because in Java, arrays are objects and objects are passed by reference, so this
method would actually mutate the coordinates array. As you point out (and as
evidenced by the fact that this bug was present), this was a poor interface. As
such, I changed the handleMouseMovement() signature to instead accept primitive
ints.

https://codereview.chromium.org/21554002/diff/1/remoting/android/java/src/org...
File remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java
(right):

https://codereview.chromium.org/21554002/diff/1/remoting/android/java/src/org...
remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java:99:
prefs.getString(hostId+"_id", ""), prefs.getString(hostId+"_secret", ""));
On 2013/08/06 20:50:32, garykac wrote:
> spaces around operators

"I don't know how those [failed to get] there..."

https://codereview.chromium.org/21554002/diff/1/remoting/android/java/src/org...
remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java:205:
R.id.pin_dialog_check)).isChecked());
On 2013/08/06 20:50:32, garykac wrote:
> Those parameters jumble together into a mess.
> 
> Something like:
> 
> authenticationResponse(
>        
>
String.valueOf(((TextView)pinEntry.findViewById(R.id.pin_dialog_text)).getText()),
>         ((CheckBox)pinEntry.findViewById(R.id.pin_dialog_check)).isChecked());
> 
> would be more readable.

After playing with this line, I settled upon the slightly odd... What do you
think?

https://codereview.chromium.org/21554002/diff/1/remoting/android/java/src/org...
remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java:250:
putString(host+"_id", new String(id)).
On 2013/08/06 20:50:32, garykac wrote:
> spaces around operators

Sorry!

[garykac, 2013-08-07 17:29:15]

lgtm

[commit-bot: I haz the power, 2013-08-07 17:32:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/solb@chromium.org/21554002/11001

[commit-bot: I haz the power, 2013-08-07 19:31:16]

Change committed as 216250