Fix ScopedPageLoadDeferrer to work with pages that have remote main frames.

Fix ScopedPageLoadDeferrer to work with pages that have remote main frames.

BUG=628942
Committed: https://crrev.com/07ff366089e56cb17712457e3f5e8469f034631b
Cr-Commit-Position: refs/heads/master@{#406632}

[alexmos, 2016-07-18 23:36:38]

The CQ bit was checked by alexmos@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 23:37:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 01:51:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 01:51:23]

Dry run: This issue passed the CQ dry run.

[dcheng, 2016-07-19 02:00:39]

dcheng@chromium.org changed reviewers:
+ dcheng@chromium.org

[dcheng, 2016-07-19 02:00:39]

Code change LGTM

I wonder if we should have a test for this checked in?

[Mike West, 2016-07-19 08:56:42]

On 2016/07/19 at 02:00:39, dcheng wrote:
> Code change LGTM
> 
> I wonder if we should have a test for this checked in?

We're going to have to merge this back to 52. I'd suggest just landing the whole
thing at once, including a test. Not regressing is pretty important.

The code change LGTM too, BTW. Thanks for putting it together more quickly.

[alexmos, 2016-07-19 23:11:20]

alexmos@chromium.org changed reviewers:
+ mkwst@chromium.org

[alexmos, 2016-07-19 23:11:21]

Thanks, I added a test - can you please take a look at it?  Note that I couldn't
test an actual load attempt being deferred while in ScopedPageLoadDeferrer
because blink::WebURLLoaderMock::setDefersLoading isn't implemented.

[dcheng, 2016-07-20 02:08:57]

lgtm with a nit

https://codereview.chromium.org/2155393002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/tests/WebFrameTest.cpp (right):

https://codereview.chromium.org/2155393002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/tests/WebFrameTest.cpp:8191:
EXPECT_FALSE(remoteRoot->toImplBase()->frame()->page()->defersLoading());
Nit: page->defersLoading()?

[Mike West, 2016-07-20 07:26:12]

LGTM. Thanks!

[alexmos, 2016-07-20 16:08:32]

Thanks!

https://codereview.chromium.org/2155393002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/tests/WebFrameTest.cpp (right):

https://codereview.chromium.org/2155393002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/tests/WebFrameTest.cpp:8191:
EXPECT_FALSE(remoteRoot->toImplBase()->frame()->page()->defersLoading());
On 2016/07/20 02:08:57, dcheng wrote:
> Nit: page->defersLoading()?

Done.

[alexmos, 2016-07-20 16:24:47]

Description was changed from

==========
Fix ScopedPageLoadDeferrer to work with pages that have remote main frames.

BUG=628942
==========

to

==========
Fix ScopedPageLoadDeferrer to work with pages that have remote main frames.

BUG=628942
==========

[alexmos, 2016-07-20 16:24:53]

The CQ bit was checked by alexmos@chromium.org

[alexmos, 2016-07-20 16:24:53]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org,
dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2155393002/#ps40001
(title: "dcheng's nit")

[commit-bot: I haz the power, 2016-07-20 16:25:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 19:04:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 19:04:56]

Failed to apply the patch.

[commit-bot: I haz the power, 2016-07-20 19:05:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 19:05:09]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-20 19:05:54]

Description was changed from

==========
Fix ScopedPageLoadDeferrer to work with pages that have remote main frames.

BUG=628942
==========

to

==========
Fix ScopedPageLoadDeferrer to work with pages that have remote main frames.

BUG=628942

Committed: https://crrev.com/07ff366089e56cb17712457e3f5e8469f034631b
Cr-Commit-Position: refs/heads/master@{#406632}
==========

[commit-bot: I haz the power, 2016-07-20 19:05:55]

Patchset 3 (id:??) landed as
https://crrev.com/07ff366089e56cb17712457e3f5e8469f034631b
Cr-Commit-Position: refs/heads/master@{#406632}