Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2155383002: Add an histogram to differentiate between hang types of the renderer (Closed)

Created:
4 years, 5 months ago by amineer
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Add an histogram to differentiate between hang types of the renderer We've seen a sharp augmentation of renderer hangs on Android. This histogram is meant to help identify the root cause of this renderer hangs, since it's currently hard to distinguish whether this is happening during normal browsing or during beforeunload/unload/when the page is closing. BUG=621303 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2136173003 Cr-Commit-Position: refs/heads/master@{#406039} (cherry picked from commit 639fdffbabc7a64ba11160c923af46b18d945650) Committed: https://chromium.googlesource.com/chromium/src/+/8ab6a56d2377c98129cfb09de20ece3e738eb5b1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -29 lines) Patch
M content/browser/devtools/devtools_manager_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 3 chunks +13 lines, -3 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_delegate.h View 1 chunk +16 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 4 chunks +8 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 8 chunks +35 lines, -10 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 4 chunks +20 lines, -7 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 2 chunks +7 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
amineer
4 years, 5 months ago (2016-07-18 23:41:50 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8ab6a56d2377c98129cfb09de20ece3e738eb5b1.

Powered by Google App Engine
This is Rietveld 408576698