💥 Fail compile if dx has input paths which do not end with .jar

💥 Fail compile if dx has input paths which do not end with .jar

dx tool ignores .dex input files and fails with message
"no classfiles specified".

BUG=617935
Committed: https://crrev.com/00696c0b365c35bd738110960a3886964f390356
Cr-Commit-Position: refs/heads/master@{#406362}

[pkotwicz, 2016-07-18 23:17:21]

Description was changed from

==========
Fail compile if dx has input paths which do not end with .jar

dx tool fails

BUG=
==========

to

==========
Fail compile if dx has input paths which do not end with .jar

dx tool ignores .dex input files and fails with message
"no classfiles specified".

BUG=617935
==========

[pkotwicz, 2016-07-18 23:17:21]

pkotwicz@chromium.org changed reviewers:
+ agrieve@chromium.org

[pkotwicz, 2016-07-18 23:24:01]

Description was changed from

==========
Fail compile if dx has input paths which do not end with .jar

dx tool ignores .dex input files and fails with message
"no classfiles specified".

BUG=617935
==========

to

==========
💥 Fail compile if dx has input paths which do not end with .jar

dx tool ignores .dex input files and fails with message
"no classfiles specified".

BUG=617935
==========

[pkotwicz, 2016-07-18 23:24:13]

Andrew can you please take a look?

[agrieve, 2016-07-19 00:00:22]

lgtm

https://codereview.chromium.org/2155363002/diff/20001/build/android/gyp/dex.py
File build/android/gyp/dex.py (right):

https://codereview.chromium.org/2155363002/diff/20001/build/android/gyp/dex.p...
build/android/gyp/dex.py:18: def _CheckFilePathEndsWithJar(parser, file_path):
nit: Can you add a comment here saying that we perform this check because dx
doesn't do the right thing?

https://codereview.chromium.org/2155363002/diff/20001/build/android/gyp/dex.p...
build/android/gyp/dex.py:98: if (options.proguard_enabled_input_path):
nit: drop the ()s

[pkotwicz, 2016-07-19 18:55:39]

Patchset #3 (id:40001) has been deleted

[pkotwicz, 2016-07-19 18:56:56]

Patchset #3 (id:60001) has been deleted

[pkotwicz, 2016-07-19 18:58:03]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2016-07-19 18:58:03]

The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2155363002/#ps80001
(title: "Merge branch 'fix_64bit' into fix_64bit_error")

[commit-bot: I haz the power, 2016-07-19 18:59:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 20:08:24]

Description was changed from

==========
💥 Fail compile if dx has input paths which do not end with .jar

dx tool ignores .dex input files and fails with message
"no classfiles specified".

BUG=617935
==========

to

==========
💥 Fail compile if dx has input paths which do not end with .jar

dx tool ignores .dex input files and fails with message
"no classfiles specified".

BUG=617935
==========

[commit-bot: I haz the power, 2016-07-19 20:08:25]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-07-19 20:08:32]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-19 20:10:34]

Description was changed from

==========
💥 Fail compile if dx has input paths which do not end with .jar

dx tool ignores .dex input files and fails with message
"no classfiles specified".

BUG=617935
==========

to

==========
💥 Fail compile if dx has input paths which do not end with .jar

dx tool ignores .dex input files and fails with message
"no classfiles specified".

BUG=617935

Committed: https://crrev.com/00696c0b365c35bd738110960a3886964f390356
Cr-Commit-Position: refs/heads/master@{#406362}
==========

[commit-bot: I haz the power, 2016-07-19 20:10:35]

Patchset 3 (id:??) landed as
https://crrev.com/00696c0b365c35bd738110960a3886964f390356
Cr-Commit-Position: refs/heads/master@{#406362}