Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 2155333002: Test for auth dialog appearing during save-page-as.

Created:
3 years, 7 months ago by Łukasz Anforowicz
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, asanka
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Preventing auth dialogs from appearing during save-page-as. If the user authenticated previously, we should reuse the credentials while saving the page and its resources. Otherwise, we shouldn't prompt the user for credentials while saving the page. BUG=629285

Patch Set 1 #

Patch Set 2 : Added a bug number. #

Patch Set 3 : Prevent prompts during save-page-as. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -29 lines) Patch
M chrome/browser/download/save_page_browsertest.cc View 1 2 12 chunks +51 lines, -29 lines 0 comments Download
M chrome/test/data/save_page/broken-image.htm View 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1 (1 generated)
Łukasz Anforowicz
3 years, 7 months ago (2016-07-18 23:12:01 UTC) #1
Description was changed from

==========
Test for auth dialog appearing during save-page-as.

BUG=629285
==========

to

==========
Preventing auth dialogs from appearing during save-page-as.

If the user authenticated previously, we should reuse the credentials
while saving the page and its resources.  Otherwise, we shouldn't prompt
the user for credentials while saving the page.

BUG=629285
==========

Powered by Google App Engine
This is Rietveld 408576698