Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 215533002: SkOnce for SkXfermode::Create(Mode) (Closed)

Created:
6 years, 9 months ago by mtklein_C
Modified:
6 years, 9 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

SkOnce for SkXfermode::Create(Mode) This removes the mutex from the fast path when we've already cached it. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13986

Patch Set 1 #

Total comments: 2

Patch Set 2 : period #

Patch Set 3 : = NULL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -47 lines) Patch
M src/core/SkXfermode.cpp View 1 2 4 chunks +51 lines, -47 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
mtklein
6 years, 9 months ago (2014-03-27 21:37:53 UTC) #1
bungeman-skia
https://codereview.chromium.org/215533002/diff/1/src/core/SkXfermode.cpp File src/core/SkXfermode.cpp (left): https://codereview.chromium.org/215533002/diff/1/src/core/SkXfermode.cpp#oldcode1699 src/core/SkXfermode.cpp:1699: // so we can just return NULL from the ...
6 years, 9 months ago (2014-03-28 18:08:07 UTC) #2
mtklein
https://codereview.chromium.org/215533002/diff/1/src/core/SkXfermode.cpp File src/core/SkXfermode.cpp (left): https://codereview.chromium.org/215533002/diff/1/src/core/SkXfermode.cpp#oldcode1699 src/core/SkXfermode.cpp:1699: // so we can just return NULL from the ...
6 years, 9 months ago (2014-03-28 18:08:43 UTC) #3
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 9 months ago (2014-03-28 18:08:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/215533002/20001
6 years, 9 months ago (2014-03-28 18:09:05 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 18:09:07 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 9 months ago (2014-03-28 18:09:07 UTC) #7
bungeman-skia
lgtm
6 years, 9 months ago (2014-03-28 18:11:03 UTC) #8
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 9 months ago (2014-03-28 18:11:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/215533002/20001
6 years, 9 months ago (2014-03-28 18:11:15 UTC) #10
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 9 months ago (2014-03-28 19:30:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/215533002/30001
6 years, 9 months ago (2014-03-28 19:30:13 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 20:04:23 UTC) #13
Message was sent while issue was closed.
Change committed as 13986

Powered by Google App Engine
This is Rietveld 408576698