Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 2155323002: Revert of analyze: ignore changes to OWNERS files (Closed)

Created:
4 years, 5 months ago by Dirk Pranke
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of analyze: ignore changes to OWNERS files (patchset #2 id:20001 of https://codereview.chromium.org/2117363002/ ) Reason for revert: reverting this since I don't think it should've been needed and I'd like to look at the problem further. I will re-land or fix as appropriate if I can reproduce the underlying bug. Original issue's description: > analyze: ignore changes to OWNERS files > > BUG=595176 > > Committed: https://crrev.com/f63a13b37a2ed66080bc4b91cff9cc1fa3678cb5 > Cr-Commit-Position: refs/heads/master@{#403797} TBR=emso@chromium.org,sergiyb@chromium.org,tandrii@chromium.org,jam@chromium.org,phajdan.jr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=595176 Committed: https://crrev.com/e3b09da02110580d4897279825c96ccf791079c1 Cr-Commit-Position: refs/heads/master@{#406152}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M testing/buildbot/trybot_analyze_config.json View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Dirk Pranke
Created Revert of analyze: ignore changes to OWNERS files
4 years, 5 months ago (2016-07-18 21:58:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2155323002/1
4 years, 5 months ago (2016-07-18 21:59:52 UTC) #3
jam
lgtm
4 years, 5 months ago (2016-07-18 23:50:16 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 23:50:32 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 23:50:34 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 23:52:32 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3b09da02110580d4897279825c96ccf791079c1
Cr-Commit-Position: refs/heads/master@{#406152}

Powered by Google App Engine
This is Rietveld 408576698