Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2155313002: milo: add builder title to swarming build page (Closed)

Created:
4 years, 5 months ago by nodir
Modified:
4 years, 5 months ago
Reviewers:
Ryan Tseng, estaab, hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, andrew.wang, todd, tandrii+luci-go_chromium.org, M-A Ruel
Base URL:
https://chromium.googlesource.com/external/github.com/luci/luci-go@master
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

milo: add builder title to swarming build page add builder title to swarming build page that includes - task id - link to the buildbucket builder view - os logo banner R=estaab@chromium.org, hinoka@chromium.org BUG=613582 Committed: https://github.com/luci/luci-go/commit/aac40ec51e94a9ff1bbc7ed0633c4e3a08caa913

Patch Set 1 #

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -8 lines) Patch
M appengine/cmd/milo/swarming/build.go View 1 4 chunks +82 lines, -0 lines 0 comments Download
M appengine/cmd/milo/swarming/expectations/build-canceled.json View 1 chunk +18 lines, -3 lines 0 comments Download
M appengine/cmd/milo/swarming/expectations/build-hang.json View 1 chunk +1 line, -1 line 0 comments Download
M appengine/cmd/milo/swarming/expectations/build-pending.json View 1 chunk +1 line, -1 line 0 comments Download
M appengine/cmd/milo/swarming/expectations/build-timeout.json View 1 chunk +18 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
nodir
PTAL This is a final CL before we tell wider infra team that we are ...
4 years, 5 months ago (2016-07-18 21:43:05 UTC) #1
nodir
deployed https://975-2d9c0bc-tainted-nodir-dot-luci-milo.appspot.com/swarming/task/3018aa7c3fbd5b10
4 years, 5 months ago (2016-07-18 21:45:23 UTC) #2
nodir
+correct hinoka
4 years, 5 months ago (2016-07-18 21:47:08 UTC) #5
Ryan Tseng
lgtm!
4 years, 5 months ago (2016-07-18 21:51:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2155313002/20001
4 years, 5 months ago (2016-07-18 21:53:16 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 21:59:33 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/aac40ec51e94a9ff1bbc7ed0633c4e3a08caa913

Powered by Google App Engine
This is Rietveld 408576698