chrome/browser/extensions/component_migration_helper.cc - Issue 2155293002: Show the Cast toolbar icon ephemerally when Cast is in use

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/component_migration_helper.cc

Issue 2155293002: Show the Cast toolbar icon ephemerally when Cast is in use (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/app/media_router_strings.grdp ('k') | chrome/browser/profiles/profile.cc » ('j') | chrome/browser/ui/toolbar/component_toolbar_actions_factory.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/component_migration_helper.cc

diff --git a/chrome/browser/extensions/component_migration_helper.cc b/chrome/browser/extensions/component_migration_helper.cc

index 3a3c1a3ef3190cc7b6d6057c893c00aed843f263..95432c2ec6fbb6501a3f0e9a499a9e1dd45bf086 100644

--- a/chrome/browser/extensions/component_migration_helper.cc

+++ b/chrome/browser/extensions/component_migration_helper.cc

@@ -9,6 +9,7 @@

#include "chrome/browser/extensions/extension_service.h"

#include "chrome/browser/extensions/extension_system_impl.h"

#include "chrome/browser/profiles/profile.h"

+#include "chrome/browser/ui/toolbar/component_toolbar_actions_factory.h"

#include "chrome/common/pref_names.h"

#include "components/prefs/pref_registry_simple.h"

#include "components/prefs/pref_service.h"

@@ -134,6 +135,12 @@ void ComponentMigrationHelper::OnExtensionReady(

UnloadExtension(extension_id);

SetComponentActionPref(component_action_id, true);

+ if (component_action_id ==

+ ComponentToolbarActionsFactory::kMediaRouterActionId) {

+ pref_service_->SetBoolean(prefs::kMediaRouterAlwaysShowActionIcon,

+ true);

+ }

if (!delegate_->HasComponentAction(component_action_id))

delegate_->AddComponentAction(component_action_id);

}