chrome/browser/ui/toolbar/component_toolbar_actions_factory.h - Issue 2155293002: Show the Cast toolbar icon ephemerally when Cast is in use

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/toolbar/component_toolbar_actions_factory.h

Issue 2155293002: Show the Cast toolbar icon ephemerally when Cast is in use (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/extensions/component_migration_helper.cc ('K') | « chrome/browser/profiles/profile.cc ('k') | chrome/browser/ui/toolbar/component_toolbar_actions_factory.cc » ('j') | chrome/browser/ui/toolbar/media_router_action.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_UI_TOOLBAR_COMPONENT_TOOLBAR_ACTIONS_FACTORY_H_	5 #ifndef CHROME_BROWSER_UI_TOOLBAR_COMPONENT_TOOLBAR_ACTIONS_FACTORY_H_

6 #define CHROME_BROWSER_UI_TOOLBAR_COMPONENT_TOOLBAR_ACTIONS_FACTORY_H_	6 #define CHROME_BROWSER_UI_TOOLBAR_COMPONENT_TOOLBAR_ACTIONS_FACTORY_H_

7	7

8 #include <memory>	8 #include <memory>

9 #include <set>	9 #include <set>

10 #include <string>	10 #include <string>

(...skipping 38 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
49	49

50 // Synchronizes component action visibility and extension install status.	50 // Synchronizes component action visibility and extension install status.

51 virtual void HandleComponentMigrations(	51 virtual void HandleComponentMigrations(

52 extensions::ComponentMigrationHelper* helper,	52 extensions::ComponentMigrationHelper* helper,

53 Profile* profile) const;	53 Profile* profile) const;

54	54

55 // Sets the factory to use for testing purposes.	55 // Sets the factory to use for testing purposes.

56 // Ownership remains with the caller.	56 // Ownership remains with the caller.

57 static void SetTestingFactory(ComponentToolbarActionsFactory* factory);	57 static void SetTestingFactory(ComponentToolbarActionsFactory* factory);

58	58

	59 // Returns whether the given ID belongs to a component action

	60 bool IsComponentActionId(const std::string& id);
	msw 2016/07/26 19:59:31 nit: make this static nit: make this static takumif 2016/07/28 20:04:10 Done. Show quoted text On 2016/07/26 19:59:31, msw wrote: > nit: make this static Done.
	61

59 private:	62 private:

60 DISALLOW_COPY_AND_ASSIGN(ComponentToolbarActionsFactory);	63 DISALLOW_COPY_AND_ASSIGN(ComponentToolbarActionsFactory);

61 };	64 };

62	65

63 #endif // CHROME_BROWSER_UI_TOOLBAR_COMPONENT_TOOLBAR_ACTIONS_FACTORY_H_	66 #endif // CHROME_BROWSER_UI_TOOLBAR_COMPONENT_TOOLBAR_ACTIONS_FACTORY_H_

OLD	NEW