Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2155283002:
Slow Reports - Check results of SetActiveScenario in browser tests. (Closed)
|
Created:
4 years, 5 months ago by shatch Modified:
4 years, 5 months ago Reviewers:
oystein (OOO til 10th of July) CC:
chromium-reviews, tracing+reviews_chromium.org, darin-cc_chromium.org, jam, wfh+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSlow Reports - Check results of SetActiveScenario in browser tests.
Some flakiness reported here, but hard to see where it might be happening. Adding some checks to see if this helps narrow things down a bit. There's also a few tests where we fail to cleanup the scenario after, so went ahead and fixed that.
BUG=628205
Committed: https://crrev.com/cb586f6a2e6feb217b1390cbfd736b3630672081
Cr-Commit-Position: refs/heads/master@{#406391}
Patch Set 1 #
Messages
Total messages: 21 (15 generated)
The CQ bit was checked by simonhatch@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== . BUG= ========== to ========== Slow Reports - Check results of SetActiveScenario in browser tests. Some flakiness reported here, but hard to see where it might be happening. Adding some checks to see if this helps narrow things down a bit. BUG=628205 ==========
Description was changed from ========== Slow Reports - Check results of SetActiveScenario in browser tests. Some flakiness reported here, but hard to see where it might be happening. Adding some checks to see if this helps narrow things down a bit. BUG=628205 ========== to ========== Slow Reports - Check results of SetActiveScenario in browser tests. Some flakiness reported here, but hard to see where it might be happening. Adding some checks to see if this helps narrow things down a bit. There's also a few tests where we fail to cleanup the scenario after, so went ahead and fixed that. BUG=628205 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by simonhatch@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:1) has been deleted
simonhatch@chromium.org changed reviewers: + oysteine@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by simonhatch@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Slow Reports - Check results of SetActiveScenario in browser tests. Some flakiness reported here, but hard to see where it might be happening. Adding some checks to see if this helps narrow things down a bit. There's also a few tests where we fail to cleanup the scenario after, so went ahead and fixed that. BUG=628205 ========== to ========== Slow Reports - Check results of SetActiveScenario in browser tests. Some flakiness reported here, but hard to see where it might be happening. Adding some checks to see if this helps narrow things down a bit. There's also a few tests where we fail to cleanup the scenario after, so went ahead and fixed that. BUG=628205 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Slow Reports - Check results of SetActiveScenario in browser tests. Some flakiness reported here, but hard to see where it might be happening. Adding some checks to see if this helps narrow things down a bit. There's also a few tests where we fail to cleanup the scenario after, so went ahead and fixed that. BUG=628205 ========== to ========== Slow Reports - Check results of SetActiveScenario in browser tests. Some flakiness reported here, but hard to see where it might be happening. Adding some checks to see if this helps narrow things down a bit. There's also a few tests where we fail to cleanup the scenario after, so went ahead and fixed that. BUG=628205 Committed: https://crrev.com/cb586f6a2e6feb217b1390cbfd736b3630672081 Cr-Commit-Position: refs/heads/master@{#406391} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/cb586f6a2e6feb217b1390cbfd736b3630672081 Cr-Commit-Position: refs/heads/master@{#406391} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
