chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc - Issue 2155243007: Turn Bookmark Menus Async

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc

Issue 2155243007: Turn Bookmark Menus Async (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc

index 50d190f58cdc4f9d3eda60a873a4bfff686ccfdb..4edbd56b79d6115643f439834bc8e6566a833620 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc

+++ b/chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc

@@ -244,8 +244,9 @@ void BookmarkEditorView::ShowContextMenuForView(

tree_model_->GetRoot());

context_menu_runner_.reset(new views::MenuRunner(

- GetMenuModel(),

- views::MenuRunner::HAS_MNEMONICS | views::MenuRunner::CONTEXT_MENU));

+ GetMenuModel(), views::MenuRunner::HAS_MNEMONICS |

+ views::MenuRunner::CONTEXT_MENU |

+ views::MenuRunner::ASYNC));

if (context_menu_runner_->RunMenuAt(source->GetWidget()->GetTopLevelWidget(),

NULL,