chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc - Issue 2155243007: Turn Bookmark Menus Async

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc

Issue 2155243007: Turn Bookmark Menus Async (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove nested flag Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc ('k') | ui/views/controls/menu/activation_change_observer_impl.h » ('j') | ui/views/controls/menu/activation_change_observer_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc b/chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc

index a5f4eab6d2e88f80a0040a6a21e2fadd336af085..5a0906d24e99bc774d766ac878a8127ca6dde084 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc

+++ b/chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc

@@ -39,8 +39,10 @@ BookmarkMenuController::BookmarkMenuController(Browser* browser,

menu_delegate_->Init(this, NULL, node, start_child_index,

BookmarkMenuDelegate::HIDE_PERMANENT_FOLDERS,

BOOKMARK_LAUNCH_LOCATION_BAR_SUBFOLDER);

- menu_runner_.reset(new views::MenuRunner(

- menu_delegate_->menu(), for_drop ? views::MenuRunner::FOR_DROP : 0));

+ int run_type = views::MenuRunner::ASYNC;

+ if (for_drop)

+ run_type |= views::MenuRunner::FOR_DROP;

+ menu_runner_.reset(new views::MenuRunner(menu_delegate_->menu(), run_type));

}

void BookmarkMenuController::RunMenuAt(BookmarkBarView* bookmark_bar) {