Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAPI.js

Issue 2155173003: Revert of Make the extension's sidebar pane auto-resizable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAPI.js
diff --git a/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAPI.js b/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAPI.js
index 679b9633161659cad5e501c3cb70360befb10733..850fb24d9c3f1737340aa37303ce23587c604a98 100644
--- a/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAPI.js
+++ b/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAPI.js
@@ -81,6 +81,7 @@
SetOpenResourceHandler: "setOpenResourceHandler",
SetResourceContent: "setResourceContent",
SetSidebarContent: "setSidebarContent",
+ SetSidebarHeight: "setSidebarHeight",
SetSidebarPage: "setSidebarPage",
ShowPanel: "showPanel",
StopAuditCategoryRun: "stopAuditCategoryRun",
@@ -385,20 +386,6 @@
return object[newName];
}
object.__defineGetter__(oldName, getter);
-}
-
-function defineDeprecatedMethod(object, className, oldName)
-{
- var warningGiven = false;
- function noop()
- {
- if (warningGiven)
- return;
-
- console.warn(className + "." + oldName + " is deprecated, please don't use it. It is a no-op.");
- warningGiven = true;
- }
- object[oldName] = noop;
}
function extractCallbackArgument(args)
@@ -494,10 +481,14 @@
function ExtensionSidebarPaneImpl(id)
{
ExtensionViewImpl.call(this, id);
- defineDeprecatedMethod(this, "ExtensionSidebarPane", "setHeight");
}
ExtensionSidebarPaneImpl.prototype = {
+ setHeight: function(height)
+ {
+ extensionServer.sendRequest({ command: commands.SetSidebarHeight, id: this._id, height: height });
+ },
+
setExpression: function(expression, rootTitle, evaluateOptions)
{
var request = {

Powered by Google App Engine
This is Rietveld 408576698