Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issue 2155173003: Revert of Make the extension's sidebar pane auto-resizable. (Closed)

Created:
4 years, 5 months ago by caseq
Modified:
4 years, 5 months ago
Reviewers:
paulirish, paulirish, kdzwinel, pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, devtools-reviews_chromium.org, extensions-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make the extension's sidebar pane auto-resizable. (patchset #7 id:120001 of https://codereview.chromium.org/1905493002/ ) Reason for revert: Regression: sources tab extension panels do not render correctly BUG=622456 Original issue's description: > Make the extension's sidebar pane auto-resizable. > > Setting height of the sidebar pane is a relic from the old design where panes were expandable (https://developer.chrome.com/static/images/devtools-panels.png). In the current design, where panes are tabs, it doesn't make sense. > > BUG=438126 > > Committed: https://crrev.com/7ff544f5fa1d09072def5419d74f8c0e5f42365e > Cr-Commit-Position: refs/heads/master@{#391965} TBR=paulirish@chromium.com,pfeldman@chromium.com,paulirish@chromium.org,kdzwinel@gmail.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=438126 Committed: https://crrev.com/ef2e81f79aeedf664fe23d88c5492ae27e5d6a2a Cr-Commit-Position: refs/heads/master@{#406149}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -20 lines) Patch
M AUTHORS View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/extensions/extensions-sidebar.html View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/extensions/extensions-sidebar-expected.txt View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAPI.js View 3 chunks +6 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js View 2 chunks +11 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
caseq
Created Revert of Make the extension's sidebar pane auto-resizable.
4 years, 5 months ago (2016-07-18 21:57:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2155173003/1
4 years, 5 months ago (2016-07-18 21:59:04 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 23:48:15 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 23:48:17 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 23:50:13 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ef2e81f79aeedf664fe23d88c5492ae27e5d6a2a
Cr-Commit-Position: refs/heads/master@{#406149}

Powered by Google App Engine
This is Rietveld 408576698