Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2155163004: Revert of Fix rewinding bug in SkJpegCodec (Closed)

Created:
4 years, 5 months ago by msarett
Modified:
4 years, 5 months ago
Reviewers:
djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Fix rewinding bug in SkJpegCodec (patchset #1 id:1 of https://codereview.chromium.org/2161593003/ ) Reason for revert: Breaking Google3 build. Will reland corrected version. Original issue's description: > Fix rewinding bug in SkJpegCodec > > Performing a sampled and/or subset decode will create some state > in SkJpegCodec. If we fail to clean up this state properly, > subsequent decodes may try to reuse (and potentailly overflow) > the leftover memory. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2161593003 > > Committed: https://skia.googlesource.com/skia/+/4ecb8ab556214c9337f56bc36d50e4d7c655ac7a TBR=djsollen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/db00a2a9eb3000f534fa0e22dae737862b933d71

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -34 lines) Patch
M src/codec/SkJpegCodec.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M tests/CodecTest.cpp View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
msarett
Created Revert of Fix rewinding bug in SkJpegCodec
4 years, 5 months ago (2016-07-18 22:19:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2155163004/1
4 years, 5 months ago (2016-07-18 22:19:44 UTC) #3
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 22:19:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/db00a2a9eb3000f534fa0e22dae737862b933d71

Powered by Google App Engine
This is Rietveld 408576698