Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: tools/perf/benchmarks/system_health.py

Issue 2155163003: [perfbot sheriff] Disable v8.browsing_mobile and sh.memory_mobile on N9 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/perf/benchmarks/v8_browsing.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/system_health.py
diff --git a/tools/perf/benchmarks/system_health.py b/tools/perf/benchmarks/system_health.py
index 28bd93557f833ed78520a3e25a955483b5ce8db4..230cc9a8b6a08568082a5d86f04028d7ed743d68 100644
--- a/tools/perf/benchmarks/system_health.py
+++ b/tools/perf/benchmarks/system_health.py
@@ -110,10 +110,16 @@ class MobileMemorySystemHealth(_MemorySystemHealthBenchmark):
@classmethod
def ShouldDisable(cls, possible_browser):
- # http://crbug.com/612144 (reference on Nexus 5X).
- return possible_browser.platform.GetDeviceTypeName() == 'Desktop' or (
- possible_browser.browser_type == 'reference' and
- possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X')
+ # http://crbug.com/612144
+ if (possible_browser.browser_type == 'reference' and
+ possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X'):
+ return True
+
+ # http://crbug.com/629163
+ if possible_browser.platform.GetDeviceTypeName() == 'Nexus 9':
+ return True
+
+ return possible_browser.platform.GetDeviceTypeName() == 'Desktop'
@benchmark.Enabled('android-webview')
« no previous file with comments | « no previous file | tools/perf/benchmarks/v8_browsing.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698