Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 2155153002: [interpreter] Update ForInPrepare to conditionally use runtime. (Closed)

Created:
4 years, 5 months ago by oth
Modified:
4 years, 5 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Update ForInPrepare to conditionally use runtime. Copies the behaviour of FullCode in attempting to get the state for ForInPrepare inline and falling back to the runtime if necessary. BUG=v8:4280 LOG=N Committed: https://crrev.com/263131cf2afd3488e2cf47fe1063f7738620783e Cr-Commit-Position: refs/heads/master@{#37874}

Patch Set 1 #

Patch Set 2 : Fix failed webkit test. #

Patch Set 3 : Rebase #

Total comments: 20

Patch Set 4 : Incorporate comments on patch set 3. #

Patch Set 5 : Trim interpreter assembler. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -12 lines) Patch
M src/code-stub-assembler.h View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M src/code-stub-assembler.cc View 1 2 3 1 chunk +67 lines, -0 lines 0 comments Download
M src/interpreter/interpreter.h View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 2 3 3 chunks +97 lines, -12 lines 0 comments Download

Messages

Total messages: 24 (17 generated)
oth
rmcilroy, PTAL, thanks and apologies in advance :-)
4 years, 5 months ago (2016-07-19 10:23:55 UTC) #12
rmcilroy
Overall looks good, thanks! https://codereview.chromium.org/2155153002/diff/40001/src/interpreter/interpreter-assembler.cc File src/interpreter/interpreter-assembler.cc (right): https://codereview.chromium.org/2155153002/diff/40001/src/interpreter/interpreter-assembler.cc#newcode639 src/interpreter/interpreter-assembler.cc:639: void InterpreterAssembler::CheckEnumCache(Node* receiver, Label* use_cache, ...
4 years, 5 months ago (2016-07-19 11:08:54 UTC) #15
oth
Thanks. All incorporated. The code has kept nothing_to_iterate on the deferred path. Happy to move ...
4 years, 5 months ago (2016-07-19 12:59:25 UTC) #18
rmcilroy
LGTM, thanks.
4 years, 5 months ago (2016-07-19 14:02:21 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2155153002/80001
4 years, 5 months ago (2016-07-19 14:07:12 UTC) #21
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 5 months ago (2016-07-19 14:46:33 UTC) #22
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 14:47:00 UTC) #24
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/263131cf2afd3488e2cf47fe1063f7738620783e
Cr-Commit-Position: refs/heads/master@{#37874}

Powered by Google App Engine
This is Rietveld 408576698