Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Unified Diff: components/scheduler/renderer/throttled_time_domain.h

Issue 2155143002: Fix a bug that could occasionaly cause setInterval to stop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ClearExpiredWakeups tweak. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/scheduler/renderer/throttled_time_domain.h
diff --git a/components/scheduler/renderer/throttled_time_domain.h b/components/scheduler/renderer/throttled_time_domain.h
index f274e8c081ec5e9deda710b5a06e77bd8b23d45c..e334c909450ca54ae560bd7248aaef9a04d5cb2e 100644
--- a/components/scheduler/renderer/throttled_time_domain.h
+++ b/components/scheduler/renderer/throttled_time_domain.h
@@ -6,26 +6,26 @@
#define COMPONENTS_SCHEDULER_RENDERER_THROTTLED_TIME_DOMAIN_H_
#include "base/macros.h"
-#include "components/scheduler/base/virtual_time_domain.h"
+#include "components/scheduler/base/real_time_domain.h"
namespace scheduler {
-// A time domain that's mostly a VirtualTimeDomain except that real time is used
-// when computing the delayed runtime.
-class SCHEDULER_EXPORT ThrottledTimeDomain : public VirtualTimeDomain {
+// A time domain for throttled tasks. behaves like an RealTimeDomain except it
+// relies on the owner (ThrottlingHelper) to schedule wakeups.
+class SCHEDULER_EXPORT ThrottledTimeDomain : public RealTimeDomain {
public:
ThrottledTimeDomain(TimeDomain::Observer* observer,
- base::TickClock* tick_clock);
+ const char* tracing_category);
~ThrottledTimeDomain() override;
// TimeDomain implementation:
- base::TimeTicks ComputeDelayedRunTime(base::TimeTicks time_domain_now,
- base::TimeDelta delay) const override;
const char* GetName() const override;
+ void RequestWakeup(base::TimeTicks now, base::TimeDelta delay) override;
+ bool MaybeAdvanceTime() override;
- private:
- base::TickClock* const tick_clock_; // NOT OWNED
+ using TimeDomain::ClearExpiredWakeups;
+ private:
DISALLOW_COPY_AND_ASSIGN(ThrottledTimeDomain);
};
« no previous file with comments | « components/scheduler/child/scheduler_helper_unittest.cc ('k') | components/scheduler/renderer/throttled_time_domain.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698