components/scheduler/child/scheduler_helper_unittest.cc - Issue 2155143002: Fix a bug that could occasionaly cause setInterval to stop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/scheduler/child/scheduler_helper_unittest.cc

Issue 2155143002: Fix a bug that could occasionaly cause setInterval to stop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changed ThrottledTimeDomain to be based on RealTimeDomain Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/scheduler/base/time_domain.h ('K') | « components/scheduler/child/idle_helper.cc ('k') | components/scheduler/renderer/throttled_time_domain.h » ('j') | components/scheduler/renderer/throttled_time_domain.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/scheduler/child/scheduler_helper_unittest.cc

diff --git a/components/scheduler/child/scheduler_helper_unittest.cc b/components/scheduler/child/scheduler_helper_unittest.cc

index 16754c93990e6ae9563cf15701e8eb74537900f5..73cbbdc4649fdcaf0bc6c0a0fafc2db0c7b0715c 100644

--- a/components/scheduler/child/scheduler_helper_unittest.cc

+++ b/components/scheduler/child/scheduler_helper_unittest.cc

@@ -9,6 +9,7 @@

#include "base/memory/ptr_util.h"

#include "base/test/simple_test_tick_clock.h"

#include "cc/test/ordered_simple_task_runner.h"

+#include "components/scheduler/base/lazy_now.h"

#include "components/scheduler/base/task_queue.h"

#include "components/scheduler/base/test_time_source.h"

#include "components/scheduler/child/scheduler_tqm_delegate_for_test.h"

@@ -179,7 +180,8 @@ TEST_F(SchedulerHelperTest,

EXPECT_CALL(observer, WillProcessTask(_)).Times(0);

EXPECT_CALL(observer, DidProcessTask(_)).Times(0);

- scheduler_helper_->ControlAfterWakeUpTaskRunner()->PumpQueue(true);

+ LazyNow lazy_now(clock_.get());

+ scheduler_helper_->ControlAfterWakeUpTaskRunner()->PumpQueue(&lazy_now, true);

RunUntilIdle();

}