Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: components/scheduler/base/time_domain.h

Issue 2155143002: Fix a bug that could occasionaly cause setInterval to stop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/scheduler/base/time_domain.h
diff --git a/components/scheduler/base/time_domain.h b/components/scheduler/base/time_domain.h
index 3b8db03e5c56f729b1042366faa31fa96afc7ba3..605a9fcfac09286c4a321683cfb1b91f30f7ce20 100644
--- a/components/scheduler/base/time_domain.h
+++ b/components/scheduler/base/time_domain.h
@@ -50,12 +50,10 @@ class SCHEDULER_EXPORT TimeDomain {
// Evaluate this TimeDomain's Now. Can be called from any thread.
virtual base::TimeTicks Now() const = 0;
- // Computes a runtime which is >= |time_domain_now| + |delay|. This is used to
- // allow the TimeDomain to decide if the real or virtual time should be used
- // when computing the task run time. This can be called from any thread.
- virtual base::TimeTicks ComputeDelayedRunTime(
- base::TimeTicks time_domain_now,
- base::TimeDelta delay) const = 0;
+ // The time to report to blink. This should usually be base::TimeTicks::Now()
+ // because blink expects time to be monotonically increacing and we need to
+ // guaranted this even if a task queue migrates between TimeDomains.
+ virtual base::TimeTicks BlinkNow() const = 0;
// Some TimeDomains support virtual time, this method tells us to advance time
// if possible and return true if time was advanced.

Powered by Google App Engine
This is Rietveld 408576698