Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 215503003: Reland text autosizing changes. (Closed)

Created:
6 years, 9 months ago by skobes
Modified:
6 years, 8 months ago
Reviewers:
pdr., abarth-chromium
CC:
blink-reviews, zoltan1, dsinclair, sof, eae+blinkwatch, ed+blinkwatch_opera.com, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, jchaffraix+rendering, darktears, bemjb+rendering_chromium.org, rune+blink, Inactive, rwlbuis, timvolodine, esprehn
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Reland text autosizing changes. This relands the following changes: http://crrev.com/208393008 Preserve autosizing multiplier on style recalc. http://crrev.com/209853007 Fix line height when changing multiplier. http://crrev.com/209353003 Clean up handling of autosizing state changes. These changes were reverted in http://crrev.com/212163006, because the first one broke AwSettingsTest.testLayoutAlgorithmWithTwoViews. They are safe to reland due to the fix in http://crrev.com/215063004. BUG=353309 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170471

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -45 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
A LayoutTests/fast/text-autosizing/font-scale-factor-change.html View 1 chunk +30 lines, -0 lines 0 comments Download
A LayoutTests/fast/text-autosizing/font-scale-factor-change-expected.html View 1 chunk +18 lines, -0 lines 0 comments Download
A LayoutTests/fast/text-autosizing/style-recalc-no-layout.html View 1 chunk +34 lines, -0 lines 0 comments Download
A LayoutTests/fast/text-autosizing/style-recalc-no-layout-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/css/resolver/StyleAdjuster.cpp View 2 chunks +8 lines, -0 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 chunk +4 lines, -0 lines 2 comments Download
M Source/core/frame/FrameView.cpp View 3 chunks +13 lines, -0 lines 0 comments Download
M Source/core/page/Page.cpp View 2 chunks +9 lines, -9 lines 0 comments Download
M Source/core/rendering/FastTextAutosizer.h View 5 chunks +10 lines, -8 lines 0 comments Download
M Source/core/rendering/FastTextAutosizer.cpp View 10 chunks +79 lines, -24 lines 0 comments Download
M Source/core/rendering/RenderBlock.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebViewImpl.cpp View 3 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
skobes
6 years, 9 months ago (2014-03-28 01:45:20 UTC) #1
pdr.
On 2014/03/28 01:45:20, skobes wrote: LGTM, rs=me
6 years, 9 months ago (2014-03-28 01:47:01 UTC) #2
skobes
@abarth, if this looks good to you please check the Commit: box. Thanks!
6 years, 9 months ago (2014-03-28 01:52:47 UTC) #3
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 8 months ago (2014-03-31 17:20:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skobes@chromium.org/215503003/1
6 years, 8 months ago (2014-03-31 17:20:27 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-31 17:29:23 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 8 months ago (2014-03-31 17:29:23 UTC) #7
skobes
Sorry abarth, I should have said "Please LGTM the change, and *then* check the Commit ...
6 years, 8 months ago (2014-03-31 17:38:02 UTC) #8
abarth-chromium
lgtm https://codereview.chromium.org/215503003/diff/1/Source/core/dom/Document.cpp File Source/core/dom/Document.cpp (right): https://codereview.chromium.org/215503003/diff/1/Source/core/dom/Document.cpp#newcode2072 Source/core/dom/Document.cpp:2072: // FTA can't update render view info while ...
6 years, 8 months ago (2014-03-31 17:58:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skobes@chromium.org/215503003/1
6 years, 8 months ago (2014-03-31 17:58:56 UTC) #10
commit-bot: I haz the power
Change committed as 170471
6 years, 8 months ago (2014-03-31 18:35:00 UTC) #11
skobes
6 years, 8 months ago (2014-03-31 18:35:55 UTC) #12
Message was sent while issue was closed.
https://codereview.chromium.org/215503003/diff/1/Source/core/dom/Document.cpp
File Source/core/dom/Document.cpp (right):

https://codereview.chromium.org/215503003/diff/1/Source/core/dom/Document.cpp...
Source/core/dom/Document.cpp:2072: // FTA can't update render view info while
the Document is detached, so update now in case anything changed.
On 2014/03/31 17:58:48, abarth wrote:
> FTA <-- Please don't use acronyms. Most folks don't know what FTA is.

Noted, will fix in a follow up patch.

Powered by Google App Engine
This is Rietveld 408576698