Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 2155023002: Don't schedule SOURCE_KIND computation when it is know already. (Closed)

Created:
4 years, 5 months ago by scheglov
Modified:
4 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't schedule SOURCE_KIND computation when it is know already. This fixes the problem when after limited invalidation we put the changed source into the unknownSourceQueue, and schedule computation of SOURCE_KIND, which actually never happens, because it is already valid. The limited invalidation test will follow in a sepatate CL, because it depends on fixing the modificationTime problem I sent for review earlier. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/111cd73778675a7a29bc03e2ef6ecda846167de4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M pkg/analyzer/lib/src/task/dart_work_manager.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/task/dart_work_manager_test.dart View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 5 months ago (2016-07-16 23:10:31 UTC) #1
Brian Wilkerson
lgtm
4 years, 5 months ago (2016-07-18 13:36:23 UTC) #2
scheglov
4 years, 5 months ago (2016-07-18 15:28:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
111cd73778675a7a29bc03e2ef6ecda846167de4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698