Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2155013002: Always update 'modificationTime' in _sourceChanged(). (Closed)

Created:
4 years, 5 months ago by scheglov
Modified:
4 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Always update 'modificationTime' in _sourceChanged(). We are going to make the entry to correspond the new source state, by performing either limited or full invaliation. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/63cccd0c5b734aed3de4e30a56b0ae3cdcffa1d1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -14 lines) Patch
M pkg/analyzer/lib/src/context/context.dart View 1 chunk +17 lines, -13 lines 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 3 chunks +22 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 5 months ago (2016-07-16 22:42:36 UTC) #1
Brian Wilkerson
lgtm
4 years, 5 months ago (2016-07-18 13:34:51 UTC) #2
scheglov
4 years, 5 months ago (2016-07-18 15:26:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
63cccd0c5b734aed3de4e30a56b0ae3cdcffa1d1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698