Reland: PVer4: Keep track of the smallest hashes not their sizes.

Reland: PVer4: Keep track of the smallest hashes not their sizes.
Also, replace counters with iterators to avoid multiplications

---
Original CL: https://codereview.chromium.org/2145163003/
Original description:
PVer4: Keep track of the smallest hashes not their sizes.
Also, replace counters with iterators to avoid multiplications

BUG=543161
Committed: https://crrev.com/4386b67601ca07f067fa21e21ae7d42dd1430ee3
Cr-Commit-Position: refs/heads/master@{#405662}
---

BUG=543161
Committed: https://crrev.com/92377d2ba2f14ff0ed48c68ea961b26a743d0908
Cr-Commit-Position: refs/heads/master@{#406021}

[vakh (use Gerrit instead), 2016-07-16 01:00:18]

Don't increment the iterator past the end. Check first.

[vakh (use Gerrit instead), 2016-07-16 01:00:23]

The CQ bit was checked by vakh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-16 01:00:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vakh (use Gerrit instead), 2016-07-16 01:00:52]

vakh@chromium.org changed reviewers:
+ nparker@chromium.org

[commit-bot: I haz the power, 2016-07-16 02:06:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-16 02:06:54]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Nathan Parker, 2016-07-18 16:14:21]

https://codereview.chromium.org/2154973002/diff/20001/components/safe_browsin...
File components/safe_browsing_db/v4_store.cc (right):

https://codereview.chromium.org/2154973002/diff/20001/components/safe_browsin...
components/safe_browsing_db/v4_store.cc:206:
static_cast<PrefixSize>(std::distance(start, hash_prefixes.end()))) {
What was wrong with the code before?

[vakh (use Gerrit instead), 2016-07-18 16:21:43]

It was incrementing the counter beyond end(), which is an undefined
operation, and this was causing a debug alert dialog to appear on Windows
in debug builds.

On Jul 18, 2016 9:14 AM, <nparker@chromium.org> wrote:

>
>
>
https://codereview.chromium.org/2154973002/diff/20001/components/safe_browsin...
> File components/safe_browsing_db/v4_store.cc (right):
>
>
>
https://codereview.chromium.org/2154973002/diff/20001/components/safe_browsin...
> components/safe_browsing_db/v4_store.cc:206:
> static_cast<PrefixSize>(std::distance(start, hash_prefixes.end()))) {
> What was wrong with the code before?
>
> https://codereview.chromium.org/2154973002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nathan Parker, 2016-07-18 16:29:50]

lgtm

[vakh (use Gerrit instead), 2016-07-18 16:30:46]

The CQ bit was checked by vakh@chromium.org

[commit-bot: I haz the power, 2016-07-18 16:31:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 17:21:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-18 17:21:20]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-18 17:23:13]

Description was changed from

==========
Reland: PVer4: Keep track of the smallest hashes not their sizes.
Also, replace counters with iterators to avoid multiplications

---
Original CL: https://codereview.chromium.org/2145163003/
Original description:
PVer4: Keep track of the smallest hashes not their sizes.
Also, replace counters with iterators to avoid multiplications

BUG=543161
Committed: https://crrev.com/4386b67601ca07f067fa21e21ae7d42dd1430ee3
Cr-Commit-Position: refs/heads/master@{#405662}
---

BUG=543161
==========

to

==========
Reland: PVer4: Keep track of the smallest hashes not their sizes.
Also, replace counters with iterators to avoid multiplications

---
Original CL: https://codereview.chromium.org/2145163003/
Original description:
PVer4: Keep track of the smallest hashes not their sizes.
Also, replace counters with iterators to avoid multiplications

BUG=543161
Committed: https://crrev.com/4386b67601ca07f067fa21e21ae7d42dd1430ee3
Cr-Commit-Position: refs/heads/master@{#405662}
---

BUG=543161

Committed: https://crrev.com/92377d2ba2f14ff0ed48c68ea961b26a743d0908
Cr-Commit-Position: refs/heads/master@{#406021}
==========

[commit-bot: I haz the power, 2016-07-18 17:23:14]

Patchset 2 (id:??) landed as
https://crrev.com/92377d2ba2f14ff0ed48c68ea961b26a743d0908
Cr-Commit-Position: refs/heads/master@{#406021}