Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2154943002: Assert using realpath when confirming "env". (Closed)

Created:
4 years, 5 months ago by dnj
Modified:
4 years, 5 months ago
Reviewers:
dnj (Google), martiniss
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Base URL:
https://github.com/luci/recipes-py@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Assert using realpath when confirming "env". On the Infra 32-bit Trusty builder, this caused a problem because the THIRD_PARTY was resolving to a symlink directory, but the importer was importing using the symlink-resolved path. Fix this by improving the assertion to specifically care that the realpath matches. BUG=chromium:628770 TEST=local - Ran this on the failing builder, confirmed that it works. Committed: https://github.com/luci/recipes-py/commit/1f4e7683113215117af63084dfef12ef06ac2896

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M recipe_engine/env.py View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
martiniss
lgtm
4 years, 5 months ago (2016-07-15 23:25:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2154943002/1
4 years, 5 months ago (2016-07-15 23:26:24 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 23:28:40 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/recipes-py/commit/1f4e7683113215117af63084dfef12ef06a...

Powered by Google App Engine
This is Rietveld 408576698