Add example int doc for Iterable.expand

Add example int doc for Iterable.expand

The expand function is not trivial and an example helps flesh out its
behaviour.

BUG=
R=floitsch@google.com

Committed: https://github.com/dart-lang/sdk/commit/0648e2622b2cc7d960993e51024108600be8c0b0

[stanm, 2016-07-15 22:56:09]

stanm@google.com changed reviewers:
+ jmesserly@google.com, lrn@google.com

[stanm, 2016-07-15 22:56:09]

CC'ing Lasse as he's the last person who's edited that comment.

[stanm, 2016-08-04 19:35:56]

stanm@google.com changed reviewers:
+ floitsch@google.com

[stanm, 2016-08-04 19:35:56]

bump

[floitsch, 2016-08-05 09:38:40]

LGTM. (although I'm pretty much asking you to rewrite everything...)

https://codereview.chromium.org/2154933002/diff/1/sdk/lib/core/iterable.dart
File sdk/lib/core/iterable.dart (right):

https://codereview.chromium.org/2154933002/diff/1/sdk/lib/core/iterable.dart#...
sdk/lib/core/iterable.dart:189: *     print(ints);
I prefer not to write the type arguments and sets:

var pairs = [[1, 2], [3, 4]];
var flattened = pairs.expand((pair) => pair).toList();
print(flattened);  // => [1, 2, 3, 4];

var input = [1, 2, 3];
var duplicated = input.expand((i) => [i, i]).toList();
print(duplicated);  // => [1, 1, 2, 2, 3, 3]

[stanm, 2016-08-05 16:48:31]

Addressed comment, but also ran dartfmt on the file by accident and it came up
with some good suggestions.

I can undo the formatting if you prefer, but PTAL.

https://codereview.chromium.org/2154933002/diff/1/sdk/lib/core/iterable.dart
File sdk/lib/core/iterable.dart (right):

https://codereview.chromium.org/2154933002/diff/1/sdk/lib/core/iterable.dart#...
sdk/lib/core/iterable.dart:189: *     print(ints);
On 2016/08/05 09:38:40, floitsch wrote:
> I prefer not to write the type arguments and sets:
> 
> var pairs = [[1, 2], [3, 4]];
> var flattened = pairs.expand((pair) => pair).toList();
> print(flattened);  // => [1, 2, 3, 4];
> 
> var input = [1, 2, 3];
> var duplicated = input.expand((i) => [i, i]).toList();
> print(duplicated);  // => [1, 1, 2, 2, 3, 3]

Done.

[floitsch, 2016-08-05 17:29:13]

Still LGTM.
thanks.

[stanm, 2016-08-05 17:34:46]

Description was changed from

==========
Add example int doc for Iterable.expand

The expand function is not trivial and an example helps flesh out its
behaviour.

BUG=
==========

to

==========
Add example int doc for Iterable.expand

The expand function is not trivial and an example helps flesh out its
behaviour.

BUG=
R=floitsch@google.com

Committed:
https://github.com/dart-lang/sdk/commit/0648e2622b2cc7d960993e51024108600be8c0b0
==========

[stanm, 2016-08-05 17:34:47]

Committed patchset #2 (id:20001) manually as
0648e2622b2cc7d960993e51024108600be8c0b0 (presubmit successful).

[stanm, 2016-08-05 17:35:04]

Thanks for the review.