Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.cpp

Issue 2154913002: Flip for writing mode exactly along the containing block chain. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: none Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutObject.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.cpp b/third_party/WebKit/Source/core/layout/LayoutObject.cpp
index ccef0e4d686fbe0047f7d4cccab686dc226671cd..555cedbe8a143998d35cac3fadceeae3fa93a525 100644
--- a/third_party/WebKit/Source/core/layout/LayoutObject.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutObject.cpp
@@ -1576,11 +1576,14 @@ bool LayoutObject::mapToVisualRectInAncestorSpace(const LayoutBoxModelObject* an
if (LayoutObject* parent = this->parent()) {
if (parent->isBox()) {
LayoutBox* parentBox = toLayoutBox(parent);
- if (!parentBox->mapScrollingContentsRectToBoxSpace(rect, parent == ancestor ? ApplyNonScrollOverflowClip : ApplyOverflowClip, visualRectFlags))
- return false;
+
// Never flip for SVG as it handles writing modes itself.
- if (!isSVG())
+ if (!isSVG()) {
parentBox->flipForWritingMode(rect);
+ }
wkorman 2016/07/18 23:21:28 nit: don't need the curlies
chrishtr 2016/07/18 23:26:57 Removed.
+
+ if (!parentBox->mapScrollingContentsRectToBoxSpace(rect, parent == ancestor ? ApplyNonScrollOverflowClip : ApplyOverflowClip, visualRectFlags))
+ return false;
}
return parent->mapToVisualRectInAncestorSpace(ancestor, rect, visualRectFlags);
}

Powered by Google App Engine
This is Rietveld 408576698